-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex153 GE21 chamber has shifted its position in 2023. Accordingly a new scenario is made for 2023 geometry #40783
Merged
+2,607
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletions
50
Configuration/Geometry/python/GeometryDD4hepExtended2023Reco_cff.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2021Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Configuration.Geometry.GeometryDD4hepExtended2023_cff import * | ||
|
||
# tracker | ||
from Geometry.CommonTopologies.globalTrackingGeometry_cfi import * | ||
from RecoTracker.GeometryESProducer.TrackerRecoGeometryESProducer_cfi import * | ||
from Geometry.TrackerGeometryBuilder.trackerParameters_cff import * | ||
from Geometry.TrackerNumberingBuilder.trackerTopology_cfi import * | ||
from Geometry.TrackerGeometryBuilder.idealForDigiTrackerGeometry_cff import * | ||
|
||
# calo | ||
from Geometry.CaloEventSetup.CaloTopology_cfi import * | ||
from Geometry.CaloEventSetup.CaloGeometryBuilder_cfi import * | ||
CaloGeometryBuilder = cms.ESProducer("CaloGeometryBuilder", | ||
SelectedCalos = cms.vstring("HCAL", | ||
"ZDC", | ||
"EcalBarrel", | ||
"EcalEndcap", | ||
"EcalPreshower", | ||
"TOWER", | ||
) | ||
) | ||
from Geometry.EcalAlgo.EcalGeometry_cfi import * | ||
from Geometry.HcalEventSetup.HcalGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerTopology_cfi import * | ||
from Geometry.HcalCommonData.hcalDDDRecConstants_cfi import * | ||
from Geometry.HcalEventSetup.hcalTopologyIdeal_cfi import * | ||
from Geometry.ForwardGeometry.ForwardGeometry_cfi import * | ||
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import * | ||
from Geometry.EcalMapping.EcalMapping_cfi import * | ||
from Geometry.EcalMapping.EcalMappingRecord_cfi import * | ||
|
||
# muon | ||
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import * | ||
from RecoMuon.DetLayers.muonDetLayerGeometry_cfi import * | ||
from Geometry.GEMGeometryBuilder.gemGeometry_cff import * | ||
from Geometry.CSCGeometryBuilder.idealForDigiCscGeometry_cff import * | ||
from Geometry.DTGeometryBuilder.idealForDigiDtGeometry_cff import * | ||
|
||
# forward | ||
from Geometry.ForwardGeometry.ForwardGeometry_cfi import * | ||
|
||
# pps | ||
|
||
|
14 changes: 14 additions & 0 deletions
14
Configuration/Geometry/python/GeometryDD4hepExtended2023_cff.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2021Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Configuration.Geometry.GeometryDD4hep_cff import * | ||
DDDetectorESProducer.confGeomXMLFiles = cms.FileInPath("Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2023.xml") | ||
|
||
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cff import * | ||
from Geometry.EcalCommonData.ecalSimulationParameters_cff import * | ||
from Geometry.HcalCommonData.hcalDDDSimConstants_cff import * | ||
from Geometry.MuonNumbering.muonGeometryConstants_cff import * | ||
from Geometry.MuonNumbering.muonOffsetESProducer_cff import * | ||
|
50 changes: 50 additions & 0 deletions
50
Configuration/Geometry/python/GeometryExtended2023Reco_cff.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2021Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Configuration.Geometry.GeometryExtended2023_cff import * | ||
|
||
# tracker | ||
from Geometry.CommonTopologies.globalTrackingGeometry_cfi import * | ||
from RecoTracker.GeometryESProducer.TrackerRecoGeometryESProducer_cfi import * | ||
from Geometry.TrackerGeometryBuilder.trackerParameters_cff import * | ||
from Geometry.TrackerNumberingBuilder.trackerTopology_cfi import * | ||
from Geometry.TrackerGeometryBuilder.idealForDigiTrackerGeometry_cff import * | ||
|
||
# calo | ||
from Geometry.CaloEventSetup.CaloTopology_cfi import * | ||
from Geometry.CaloEventSetup.CaloGeometryBuilder_cfi import * | ||
CaloGeometryBuilder = cms.ESProducer("CaloGeometryBuilder", | ||
SelectedCalos = cms.vstring("HCAL", | ||
"ZDC", | ||
"EcalBarrel", | ||
"EcalEndcap", | ||
"EcalPreshower", | ||
"TOWER", | ||
) | ||
) | ||
from Geometry.EcalAlgo.EcalGeometry_cfi import * | ||
from Geometry.HcalEventSetup.HcalGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerGeometry_cfi import * | ||
from Geometry.HcalEventSetup.CaloTowerTopology_cfi import * | ||
from Geometry.HcalCommonData.hcalDDDRecConstants_cfi import * | ||
from Geometry.HcalEventSetup.hcalTopologyIdeal_cfi import * | ||
from Geometry.ForwardGeometry.ForwardGeometry_cfi import * | ||
from Geometry.CaloEventSetup.EcalTrigTowerConstituents_cfi import * | ||
from Geometry.EcalMapping.EcalMapping_cfi import * | ||
from Geometry.EcalMapping.EcalMappingRecord_cfi import * | ||
|
||
# muon | ||
from Geometry.MuonNumbering.muonNumberingInitialization_cfi import * | ||
from RecoMuon.DetLayers.muonDetLayerGeometry_cfi import * | ||
from Geometry.GEMGeometryBuilder.gemGeometry_cff import * | ||
from Geometry.CSCGeometryBuilder.idealForDigiCscGeometry_cff import * | ||
from Geometry.DTGeometryBuilder.idealForDigiDtGeometry_cff import * | ||
|
||
# forward | ||
from Geometry.ForwardGeometry.ForwardGeometry_cfi import * | ||
|
||
# pps | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
# This config was generated automatically using generate2021Geometry.py | ||
# If you notice a mistake, please update the generating script, not just this config | ||
|
||
from Geometry.CMSCommonData.cmsExtendedGeometry2023XML_cfi import * | ||
from Geometry.TrackerNumberingBuilder.trackerNumberingGeometry_cff import * | ||
from Geometry.EcalCommonData.ecalSimulationParameters_cff import * | ||
from Geometry.HcalCommonData.hcalDDDSimConstants_cff import * | ||
from Geometry.MuonNumbering.muonGeometryConstants_cff import * | ||
from Geometry.MuonNumbering.muonOffsetESProducer_cff import * | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda , is it correct that dict2021Geometry includes 2023 gem entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, we have 2 dictionaries one for Run3 and one for Run4. They are names 2021 and 2026 - maybe we can change the names later. I shall ask Kevin about this. It is he who introduced this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the next technical stop the geometry will changed again. May be correct to keep dictionary for 2021 unchanged and create 2023? I mean that if we keep updating the dictionary would we need to to use it for 2022 geometry? Likely no....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can always add a new version in the dictionary. We can always define a new scenario with a suitable combination. That is why the dictionary is good. I doubt if things will change during any technical stop. It will change most likely in the next YETS for 2024. That can be easily accommodated in this scheme.