Use named constants for uG(M)T firmware versions etc. #40841

dinyar · 2023-02-21T19:39:35Z

PR description:

Use named constants for the uG(M)T firmware versions and FED IDs used by the (un)packers. Also fixed an oversight spotted by @elfontan where I had forgotten to correct the uGT firmware version in one spot.

cmsbuild · 2023-02-21T19:47:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40841/34297

This PR adds an extra 16KB to repository

cmsbuild · 2023-02-21T19:48:14Z

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

L1Trigger/L1TMuon (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @JanFSchulte, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

aloeliger · 2023-02-21T19:58:16Z

please test

aloeliger · 2023-02-21T20:08:32Z

L1Trigger/L1TMuon/interface/MuonRawDigiTranslator.h

+    static constexpr int ugmtFedId_ = 1402;
+    static constexpr int ugtFedId_ = 1404;
+    static constexpr int ugmtFwVersionUntil2016_ = 0x4010000;
+    static constexpr int ugtFwVersionUntil2016_ = 0x10A6;
+    static constexpr int ugmtFwVersionUntil2017_ = 0x6000000;
+    static constexpr int ugtFwVersionUntil2017_ = 0x1120;
+    static constexpr int ugmtFwVersionRun3Start_ = 0x6000001;
+    static constexpr int ugtFwVersionUntilRun3Start_ = 0x1130;
+    static constexpr int ugmtFwVersionFirstWithShowers_ = 0x7000000;
+    static constexpr int ugtFwVersionFirstWithShowers_ = 0x113B;


Perhaps someone can correct me on this, but I think it is preferred that if you are adding class constants, that they have prefix k in front of them?

Hi Andrew,

Ah, didn't know that but I'm happy to change it. Should I then do so for the other constants in that file too, I suppose? Also, is it fine to only do it in this PR, but not for the backport?

Cheers,
Dinyar

@dinyar It should be fine to keep old constants how they are for now, but I believe that any newly added constants should have prefix k according to http://cms-sw.github.io/cms_coding_rules.html

@dinyar And if possible I think it would be good to have the change (same commit if it all possible) in both this and the backport.

Hi @aloeliger,

Ok, done now, let me know if it's ok. I've created a separate commit for the change, but if it also goes in the backport I'd be tempted to squash it (and do the same for the backport). Is that fine?

-d

@dinyar I would think it's fine. The alternative is you could just git cherry-pick the same commit to the backport branch of your repository.

cmsbuild · 2023-02-21T23:50:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6be00/30792/summary.html
COMMIT: 4ac1e7a
CMSSW: CMSSW_13_1_X_2023-02-21-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40841/30792/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@eyigitba Fix RPC and GEM TP unpacking in EMTF unpacker #40797
@bsunanda Run3-gex153 GE21 chamber has shifted its position in 2023. Accordingly a new scenario is made for 2023 geometry #40783
@Dr15Jones Remove unused variables from RecoVertex/BeamSpotProducer #40800
@jshin96 [PileupJetId, Puppi] Pileup ID input variable fix, puppi weight ValueMap access, optional photon protection for existing puppi weights #40762
@CTPPS PPS diamond mapping XML for 2023 run #40763
@Dr15Jones Changed binary to logical operation in OptimalHelixPlaneCrossing #40810

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6be00/30792/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6be00/30792/git-merge-result

Comparison Summary

Summary:

You potentially removed 14 lines from the logs
Reco comparison results: 30 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3528709
DQMHistoTests: Total failures: 40
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3528647
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2023-02-22T17:15:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40841/34306

This PR adds an extra 16KB to repository

cmsbuild · 2023-02-22T17:16:08Z

Pull request #40841 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again.

epalencia · 2023-02-22T18:48:06Z

Please test

cmsbuild · 2023-02-22T21:17:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6be00/30817/summary.html
COMMIT: 7a51b51
CMSSW: CMSSW_13_1_X_2023-02-22-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40841/30817/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 6 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3528709
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3528687
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

Also fix overlooked incorrect uGT version from previous commit.

cmsbuild · 2023-02-23T08:37:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40841/34315

This PR adds an extra 16KB to repository

cmsbuild · 2023-02-23T08:37:58Z

Pull request #40841 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again.

aloeliger · 2023-02-23T09:35:04Z

please test

cmsbuild · 2023-02-23T12:03:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6be00/30826/summary.html
COMMIT: dd8a1f3
CMSSW: CMSSW_13_1_X_2023-02-22-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40841/30826/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
11634.596 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 5 lines to the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3528709
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3528684
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

aloeliger · 2023-02-23T13:02:28Z

+l1

cmsbuild · 2023-02-23T13:02:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-02-23T15:42:13Z

+1

cmsbuild added this to the CMSSW_13_1_X milestone Feb 21, 2023

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 21, 2023

dinyar mentioned this pull request Feb 21, 2023

[13_0_X] Fix uGT shower unpacking #40842

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 21, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 21, 2023

aloeliger reviewed Feb 21, 2023

View reviewed changes

cmsbuild added tests-approved tests-pending code-checks-pending and removed tests-started tests-approved code-checks-approved labels Feb 21, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 22, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 22, 2023

cmsbuild added tests-approved and removed tests-started labels Feb 22, 2023

Put uG(M)T firmware versions etc. into named constants

dd8a1f3

Also fix overlooked incorrect uGT version from previous commit.

dinyar force-pushed the fix/ugt_version_w_showers branch from 7a51b51 to dd8a1f3 Compare February 23, 2023 08:32

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Feb 23, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 23, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 23, 2023

cmsbuild added tests-approved and removed tests-started labels Feb 23, 2023

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Feb 23, 2023

cmsbuild added orp-approved and removed orp-pending labels Feb 23, 2023

cmsbuild merged commit 44432aa into cms-sw:master Feb 23, 2023

epalencia mentioned this pull request Mar 1, 2023

Use named constants for uG(M)T firmware versions etc (backport of 40841) cms-l1t-offline/cmssw#1073

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use named constants for uG(M)T firmware versions etc. #40841

Use named constants for uG(M)T firmware versions etc. #40841

dinyar commented Feb 21, 2023

cmsbuild commented Feb 21, 2023

cmsbuild commented Feb 21, 2023

aloeliger commented Feb 21, 2023

aloeliger Feb 21, 2023

dinyar Feb 22, 2023

aloeliger Feb 22, 2023

aloeliger Feb 22, 2023

dinyar Feb 22, 2023

aloeliger Feb 23, 2023

dinyar Feb 23, 2023

cmsbuild commented Feb 21, 2023

cmsbuild commented Feb 22, 2023

cmsbuild commented Feb 22, 2023

epalencia commented Feb 22, 2023

cmsbuild commented Feb 22, 2023

cmsbuild commented Feb 23, 2023

cmsbuild commented Feb 23, 2023

aloeliger commented Feb 23, 2023

cmsbuild commented Feb 23, 2023

aloeliger commented Feb 23, 2023

cmsbuild commented Feb 23, 2023

rappoccio commented Feb 23, 2023

Use named constants for uG(M)T firmware versions etc. #40841

Use named constants for uG(M)T firmware versions etc. #40841

Conversation

dinyar commented Feb 21, 2023

PR description:

cmsbuild commented Feb 21, 2023

cmsbuild commented Feb 21, 2023

aloeliger commented Feb 21, 2023

aloeliger Feb 21, 2023

Choose a reason for hiding this comment

dinyar Feb 22, 2023

Choose a reason for hiding this comment

aloeliger Feb 22, 2023

Choose a reason for hiding this comment

aloeliger Feb 22, 2023

Choose a reason for hiding this comment

dinyar Feb 22, 2023

Choose a reason for hiding this comment

aloeliger Feb 23, 2023

Choose a reason for hiding this comment

dinyar Feb 23, 2023

Choose a reason for hiding this comment

cmsbuild commented Feb 21, 2023

Comparison Summary

cmsbuild commented Feb 22, 2023

cmsbuild commented Feb 22, 2023

epalencia commented Feb 22, 2023

cmsbuild commented Feb 22, 2023

Comparison Summary

cmsbuild commented Feb 23, 2023

cmsbuild commented Feb 23, 2023

aloeliger commented Feb 23, 2023

cmsbuild commented Feb 23, 2023

Comparison Summary

aloeliger commented Feb 23, 2023

cmsbuild commented Feb 23, 2023

rappoccio commented Feb 23, 2023