Comments concerning the rinv bins #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matti Kortelainen <[email protected]>
Simplified first and last BX calculation and removed unnecessary virtual on setEtSumZDCCopy
Fixing formatting for cmsbuild
…hing_fix Add Herwig7HadronizerFilter to list of Filters with concurrent lumis disabled
The latter options were replaced with the former some time ago.
The latter options were replaced with the former some time ago.
The former options were replaced with the latter some time ago.
The former options were replaced with the latter some time ago.
The former options were replaced with the latter some time ago.
The former options were replaced with the latter some time ago.
The former options were replaced with the latter some time ago.
The former options were replaced with the latter some time ago.
The former options were replaced with the latter some time ago.
The former options were replaced with the latter some time ago.
The former options were replaced with the latter some time ago.
check for empty collection in SiStripApproximateClusterCollection
update input collections of `pixelgpu` online-DQM client for HI mode
unpacking map for ZDC was 71 instead of 142
Add mu beamspot constrained pT. Increase mu eta and phi precision to 16 bits
Update 2022 MC GTs for new ecal timing calibrations
MTD code: add debugging statements, clean ETL validation for obsolete one-disk scenario
Update GPU workflows
…_for133X HLT menu development for `13_2_X` (4/N) [`13_3_X`]
…_jmenano_ak4btaggerupdates [JMENano] Update taggers for AK4 Puppi and CHS
Update `FitWithRooFit` in Alignment/OfflineValidation to fix memory leaks
…s_FTV Update BeamSpot scripts for FTVs
Phase2-TB76 Add an example script which can work for 2023 July simulation
Phase2-TB76X Add an aalyzer for HGCal TB sudies using inch wafers
Improve memory usage in ParameterSet
era to store ZDC digis for pp reco
Phase2-gex171 Add a few more options to generate the single neutrino file
…l1tkemfilters_133X [Phase-2] Fixed L1 quality mask requirement in L1TkEmSingle51Filter
PPS Dump to SQLite only one record (mask or mapping)
…illTime_fix_pr fixed LHCInfoPer* PopCons not recoginizing ongoing fills in duringFill mode
tomalin
reviewed
Oct 5, 2023
| @@ -1047,6 +1047,9 @@ namespace trklet { | |||
| double stripLength_2S_{5.0250}; | |||
|
|
|||
| //Following values are used for duplicate removal | |||
| //The bin edges for rinv were chosen using the output tracks without duplicate removal for a large number of events | |||
There was a problem hiding this comment.
This text is hard to understand. e.g. In "track at that index", it's unclear what the word "index2 refers to.
tomalin
reviewed
Oct 5, 2023
| @@ -728,6 +728,15 @@ std::string Tracklet::trackfitstr() const { | |||
|
|
|||
| oss += "1|"; // valid bit | |||
| oss += tmp.str() + "|"; | |||
| if (settings_.combined()) { | |||
There was a problem hiding this comment.
Why is the C++ being changed?
Fill Photon PF ID DNN score properly
Fix condition to add anti-particle to G4ParticleTable
Added a fillDescriptions to IgProfService
Phase2-TB76Y Update the analyzer code and scripts for 2023 July HGCal Test Beam
Add FastTimer and Throughput Services to HLT Phase2 timing menu.
|
Changing 917 files in response to one small git review comment seems excessive! :-) |
I think I cloned the development branch and not the PR branch 😅. I'll go ahead and fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds some more comments explaining why the rinv bin edges in L1Trigger/TrackFindingTracklet/interface/Settings.h were chosen as such. See here cms-sw#42663 (comment).