Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD code: add debugging statements, clean ETL validation for obsolete one-disk scenario #42748

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

fabiocos
Copy link
Contributor

PR description:

This PR adds to the MTD digitization, reconstruction and validation classes a number of debugging messages, used in the investigation of the track-ETL hits matching efficiency. At the same time, the part of the validation classes that still allowed for a one-disk geometry, no more present in the release since a while, is removed.

PR validation:

Code compiles and run. Debugging statements have been actively used, but are not visible with the default MessageLogger settings. No impact on the physics output is expected.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42748/36841

  • This PR adds an extra 56KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

  • RecoMTD/TrackExtender (upgrade, reconstruction)
  • SimFastTiming/FastTimingCommon (upgrade, simulation)
  • Validation/MtdValidation (dqm)

@civanch, @nothingface0, @emanueleusai, @mdhildreth, @mandrenguyen, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

@martinamalberti FYI

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5fc23/34690/summary.html
COMMIT: cdcebfa
CMSSW: CMSSW_13_3_X_2023-09-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42748/34690/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3153414
  • DQMHistoTests: Total failures: 1496
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3151896
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Sep 11, 2023

+1

regression problems in MkFit not related to this PR.

@srimanob
Copy link
Contributor

+Upgrade

Code related to Upgrade is on debug message.

@jfernan2
Copy link
Contributor

+1

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants