-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD code: add debugging statements, clean ETL validation for obsolete one-disk scenario #42748
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42748/36841
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages:
@civanch, @nothingface0, @emanueleusai, @mdhildreth, @mandrenguyen, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@martinamalberti FYI |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f5fc23/34690/summary.html Comparison SummarySummary:
|
+1 regression problems in MkFit not related to this PR. |
+Upgrade Code related to Upgrade is on debug message. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds to the MTD digitization, reconstruction and validation classes a number of debugging messages, used in the investigation of the track-ETL hits matching efficiency. At the same time, the part of the validation classes that still allowed for a one-disk geometry, no more present in the release since a while, is removed.
PR validation:
Code compiles and run. Debugging statements have been actively used, but are not visible with the default
MessageLogger
settings. No impact on the physics output is expected.