Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-TB76Y Update the analyzer code and scripts for 2023 July HGCal Test Beam #42948

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Oct 4, 2023

PR description:

Update the analyzer code and scripts for 2023 July HGCal Test Beam

PR validation:

Tested the new analyser with the updated script

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42948/37092

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • SimG4CMS/HGCalTestBeam (simulation, upgrade)

@cmsbuild, @mdhildreth, @AdrianoDee, @srimanob, @civanch can you please review it and eventually sign? Thanks.
@slomeo, @fabiocos, @rovere this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Oct 4, 2023

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6be7e6/35043/summary.html
COMMIT: cbc4e76
CMSSW: CMSSW_13_3_X_2023-10-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42948/35043/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3356920
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3356895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Oct 5, 2023

+1

@srimanob
Copy link
Contributor

srimanob commented Oct 5, 2023

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4cb8dec into cms-sw:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants