-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Herwig7HadronizerFilter to list of Filters with concurrent lumis disabled #42732
Add Herwig7HadronizerFilter to list of Filters with concurrent lumis disabled #42732
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42732/36823
|
A new Pull Request was created by @Dominic-Stafford for master. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dae122/34675/summary.html Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dae122/34692/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Fixes the issues observed for Relvals after merging #42673 by adding Herwig7HadronizerFilter to list of EDModules that do not support concurrentLuminosityBlocks. Not yet tested since I only have a working set of externals for CMSSW_10_6 (where this issue doesn't occur), should be tested with workflows 535, 537 and 538 (ideally also with multiple threads if this can be done before merging).