-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Herwig LHE matching fix and Matchbox relval for 13_0 #45241
Herwig LHE matching fix and Matchbox relval for 13_0 #45241
Conversation
…g events Read lhe event numbers in, if present Add HadroniserFilter to Herwig which correctly matches LHE numbers between CMSSW and herwig Add option to Herwig input fragements to use LHE numbering Change test examples to use new HadroniserFilter+ LHE numbering code style code style Call addLHEnumbers from mergeLHE.py if asked to number events and not using the DefaultLHEMerger Number events before merge (so numbers are also available to LHEReader) Include evtnum in LHEEventProduct (necesary for multithreading)
A new Pull Request was created by @Dominic-Stafford for CMSSW_13_0_X. It involves the following packages:
@sunilUIET, @menglu21, @subirsarkar, @srimanob, @AdrianoDee, @GurpreetSinghChahal, @SiewYan, @alberto-sanchez, @kskovpen, @mkirsano, @bbilin, @cmsbuild, @miquork can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4eca4/39956/summary.html Comparison SummarySummary:
|
+1 |
+Upgrade |
please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
+pdmv |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Backports #42673 and #42732 (which add a new Herwig7HadronizerFilter, designed to resolve the issue of the wrong lhe events being saved with Herwig) and #43261 (which adds a new workflow 539 for testing the Matchbox mode of Herwig) for use in 2023 gen production.
Should be tested with cms-sw/cmsdist#9247 - the Herwig relvals to run are 535, 537, 538 and 539.