Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Herwig backports for 13_0 (2023 gen production) #9247

Merged

Conversation

Dominic-Stafford
Copy link
Contributor

Backports #8670 (patches to propagate LHE numbering through Herwig), #8794 (fix for seg fault in Herwig min bias), #8809 (use external collier and ninja for madgraph) and #9206 (add a collier toofile) for use in 2023 production (until now this branch had not been being maintained for backports, but we are now starting to get requests which need this to be up-to-date)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_13_0_X/master.

@iarspider, @cmsbuild, @smuzaffar, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 17, 2024

cms-bot internal usage

@Dominic-Stafford Dominic-Stafford changed the title Hw lhe match fix 13 0 Missing Herwig backports for 13_0 (2023 gen production) Jun 17, 2024
@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c824d5/39963/summary.html
COMMIT: cce5ff6
CMSSW: CMSSW_13_0_X_2024-06-16-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9247/39963/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor

+externals

@cms-sw/orp-l2 feel free to merge and include it for next 13.0 IB/release

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_0_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor

this is backport for 13.0 , lets get this merged so that we can run full IB tests

@smuzaffar smuzaffar merged commit 131b874 into cms-sw:IB/CMSSW_13_0_X/master Jun 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants