Add fix for segfault in Min Bias

[Dominic-Stafford]

A segfault was reported for generating Min Bias events with Herwig. The root cause seems to be that both the "read" and "run" steps are run in a single job (whereas in standalone Herwig they are run in two different jobs). This leads to issues as two static pointers are made to an object which is deleted and recreated between the steps, removing the static keyword seems to resolve the issue (tested in CMSSW_10_6). Herwig authors agree this seems a reasonable fix, and they plan to include it in future versions of Herwig, this patch resolves the issue in CMSSW in the meantime

[cmsbuild]

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_13_3_X/master.

@aandvalenzuela, @smuzaffar, @iarspider, @cmsbuild can you please review it and eventually sign? Thanks.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4933d1/35508/summary.html
COMMIT: 22ae316
CMSSW: CMSSW_13_3_X_2023-10-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8794/35508/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3362691
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3362657
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

assign generators

@cms-sw/generators-l2 can you please review and approve this change?

[cmsbuild]

New categories assigned: generators

@alberto-sanchez,@bbilin,@GurpreetSinghChahal,@mkirsano,@menglu21,@SiewYan you have been requested to review this Pull request/Issue and eventually sign? Thanks

[menglu21]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_13_3_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@cms-sw/orp-l2 , this is ready to go in 13.3.X, feel free to sign it

[smuzaffar]

@cms-sw/generators-l2 @cms-sw/orp-l2 , what about this fix? should this go in 13.3.X?

[antoniovilela]

@cms-sw/generators-l2 @cms-sw/orp-l2 , what about this fix? should this go in 13.3.X?

Yes, sorry for the delay.

[antoniovilela]

+1