[12.4.X] Add fix for segfault in Min Bias

[Dominic-Stafford]

Fixes a seg fault in Min Bias production due to some pointers in Herwig being incorrectly defined as static.

Backport of #8794 for 2022 gen production.

[cmsbuild]

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_12_4_X/master.

@smuzaffar, @aandvalenzuela, @cmsbuild, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

• Backported from Add fix for segfault in Min Bias #8794

[smuzaffar]

Backport of #8794

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df64b7/35551/summary.html
COMMIT: c6c49d6
CMSSW: CMSSW_12_4_X_2023-10-29-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8796/35551/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 21 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3766083
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3766041
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 167 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df64b7/35862/summary.html
COMMIT: c6c49d6
CMSSW: CMSSW_12_4_X_2023-11-12-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8796/35862/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 15 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3766083
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3766047
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 167 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

@cms-sw/orp-l2 please feel free to merge it for next 12.4.X release

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@rappoccio @antoniovilela , feel free to merge this for 12.4.X

[antoniovilela]

+1