Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collier toolfile #9206

Merged

Conversation

Dominic-Stafford
Copy link
Contributor

The standard CMS event generation workflow involves building madgraph outside of CMSSW for use in gridpacks. However due to frequent HepForge downtime we would like to be able to install the madgraph prerequisites from CMSSW (cms-sw/genproductions#3712). Collier is built in CMSSW, however it did not have a toolfile, so its directory could not be found by the scram tool info command. This PR adds a basic toolfile for collier to rectify this.

I don't have much experience with toolfiles, so please let me know if something is missing or there is a better solution.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_14_1_X/master.

@smuzaffar, @iarspider, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor

please test

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f20192/39553/summary.html
COMMIT: 541f6a4
CMSSW: CMSSW_14_1_X_2024-05-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9206/39553/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f20192/39553/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f20192/39553/git-merge-result

Comparison Summary

Summary:

  • You potentially added 26 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338862
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338836
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar merged commit 2331ea8 into cms-sw:IB/CMSSW_14_1_X/master May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants