Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] Add collier toolfile #9213

Conversation

Dominic-Stafford
Copy link
Contributor

Backport of #9206 to provide collier path for run 3 madgraph gridpack generation

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_12_4_X/master.

@smuzaffar, @cmsbuild, @iarspider, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2024

cms-bot internal usage

@smuzaffar smuzaffar changed the title Add collier toolfile [12.4.X] Add collier toolfile May 30, 2024
@iarspider
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d67399/39622/summary.html
COMMIT: ce3f823
CMSSW: CMSSW_12_4_X_2024-05-26-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9213/39622/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3766053
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@cms-sw/orp-l2, please feel free to merge it for next 12.4.X IB/release

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link

+1

@cmsbuild cmsbuild merged commit b889d1b into cms-sw:IB/CMSSW_12_4_X/master Jun 4, 2024
9 checks passed
@smuzaffar
Copy link
Contributor

@cms-sw/orp-l2 , I will not backport this PR to CMSSW_13_0_X as it also requires #8930 which was not to 13.0.X. So please go ahead with CMSSW_13_0_X release without backport of collier toolfile PR

@antoniovilela
Copy link

@cms-sw/orp-l2 , I will not backport this PR to CMSSW_13_0_X as it also requires #8930 which was not to 13.0.X. So please go ahead with CMSSW_13_0_X release without backport of collier toolfile PR

I had missed this, apologies. I will build 13_0_19 & 13_0_19_HLT (and also 13_0_19_HeavyIon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants