Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] Add Collier package and use ninja from gosamcontrib for madgraph #8930

Conversation

Dominic-Stafford
Copy link
Contributor

Backport of #8809 for use in 2022 production - requested by the Madgraph contacts so these packages can be accessed inside CMSSW in the event of hepforge downtime.

Tested with the Herwig+Madgraph matchbox workflow 539 backported in cms-sw/cmssw#43692

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2024

A new Pull Request was created by @Dominic-Stafford for branch IB/CMSSW_12_4_X/master.

@cmsbuild, @aandvalenzuela, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 10, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbc2ed/36798/summary.html
COMMIT: 1ff04f2
CMSSW: CMSSW_12_4_X_2024-01-07-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8930/36798/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3766053
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

+externals

@smuzaffar
Copy link
Contributor

@cms-sw/generators-l2 , any objections on including it for 12.4.X

@smuzaffar smuzaffar changed the title Add Collier package and use ninja from gosamcontrib for madgraph [12.4.X] Add Collier package and use ninja from gosamcontrib for madgraph Jan 18, 2024
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_12_4_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link

@cms-sw/generators-l2 , any objections on including it for 12.4.X

@cms-sw/generators-l2
Please have a look and reply.

@smuzaffar
Copy link
Contributor

Backport of #8809

@menglu21
Copy link

+1

1 similar comment
@antoniovilela
Copy link

+1

@cmsbuild cmsbuild merged commit d889f7e into cms-sw:IB/CMSSW_12_4_X/master Feb 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants