fixed LHCInfoPer* PopCons not recoginizing ongoing fills in duringFill mode

[JanChyczynski]

PR description:

Fixes bugs in LHCInfoPerFill and LHCInfoPerLS PopCons in duringFill mode causing it not to recognize a fill as ongoing. It caused the PopCons not process any fills and not write any data in this mode.

DuringFill mode is supposed to only process ongoing fills and write only one - the newest available payload for each execution during stable beam. It interprets a fill as ongoing if its end_time (taken from OMS) is null which means it didn't end. It is not checking the value for being null directly but checking if the end_time converted to cond::Time_t is equal to 0. It was not working correctly because conversion from end_time value taken from OMS as boost::posix_time::ptime to cond::Time_t converts null to 2035-10-29 06:32:22.

PR validation:

It was validated by running the PopCons via LHCInfoPerFillPopConAnalyzer.py and LHCInfoPerLSPopConAnalyzer.py with mode=duringFill during and outside of stable beam of an ongoing fill. It was checked if the payload was written given the right circumstances (ongoing stable beam) and if the written data is correct.

Backporting

I think it should be backported to 13_2_X, but it depends on what release the Per* PopCons are going to be deployed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42837/36967

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondTools/RunInfo/plugins/LHCInfoPerFillPopConAnalyzer.cc modified in PR(s): DeepCore model 2.2.1 #42816
  • File CondTools/RunInfo/plugins/LHCInfoPerLSPopConAnalyzer.cc modified in PR(s): DeepCore model 2.2.1 #42816

[cmsbuild]

A new Pull Request was created by @JanChyczynski (jan_chyczynski) for master.

It involves the following packages:

• CondTools/RunInfo (db)

@perrotta, @cmsbuild, @consuegs, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e25d98/34848/summary.html
COMMIT: 8b8e2e7
CMSSW: CMSSW_13_3_X_2023-09-20-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42837/34848/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test CondToolsLHCInfoNewPopConTest had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
24834.5 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3358044
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3358016
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

@JanChyczynski the error in the unit test is related: please have a look

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42837/36991

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #42837 was updated. @perrotta, @cmsbuild, @consuegs, @saumyaphor4252, @francescobrivio can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42837/36993

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #42837 was updated. @perrotta, @cmsbuild, @consuegs, @saumyaphor4252, @francescobrivio can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e25d98/34892/summary.html
COMMIT: 9f25c47
CMSSW: CMSSW_13_3_X_2023-09-25-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42837/34892/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3358044
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3358016
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

+db

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1