-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate entries from CondTools/RunInfo/plugins/BuildFile.xml
#42838
Remove duplicate entries from CondTools/RunInfo/plugins/BuildFile.xml
#42838
Conversation
As far as I can tell, the following lines are duplicated in this file: ```xml <library file="LHCInfoPerLSAnalyzer.cc" name="LHCInfoPerLSAnalyzer"> <flags EDM_PLUGIN="1"/> </library> <library file="LHCInfoPerFillWriter.cc" name="LHCInfoPerFillWriter"> <flags EDM_PLUGIN="1"/> </library> <library file="LHCInfoPerFillAnalyzer.cc" name="LHCInfoPerFillAnalyzer"> <flags EDM_PLUGIN="1"/> </library> ``` This unneccessarily confuses my BuildFile to CMake conversion tools, and I think it would be better to not have duplicated plugin declarations in general.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42838/36968
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages:
@perrotta, @cmsbuild, @consuegs, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@perrotta, can this be approved for db? Thanks! |
please abort |
please test |
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test CondToolsLHCInfoNewPopConTest had ERRORS Comparison SummarySummary:
|
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge
|
As far as I can tell, the following lines are duplicated towards the end of this file: