Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate entries from CondTools/RunInfo/plugins/BuildFile.xml #42838

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Remove duplicate entries from CondTools/RunInfo/plugins/BuildFile.xml #42838

merged 1 commit into from
Sep 27, 2023

Conversation

guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Sep 20, 2023

As far as I can tell, the following lines are duplicated towards the end of this file:

<library file="LHCInfoPerLSAnalyzer.cc" name="LHCInfoPerLSAnalyzer">
  <flags EDM_PLUGIN="1"/>
</library>

<library file="LHCInfoPerFillWriter.cc" name="LHCInfoPerFillWriter">
  <flags EDM_PLUGIN="1"/>
</library>

<library file="LHCInfoPerFillAnalyzer.cc" name="LHCInfoPerFillAnalyzer">
  <flags EDM_PLUGIN="1"/>
</library>

As far as I can tell, the following lines are duplicated in this file:

```xml
<library file="LHCInfoPerLSAnalyzer.cc" name="LHCInfoPerLSAnalyzer">
  <flags EDM_PLUGIN="1"/>
</library>

<library file="LHCInfoPerFillWriter.cc" name="LHCInfoPerFillWriter">
  <flags EDM_PLUGIN="1"/>
</library>

<library file="LHCInfoPerFillAnalyzer.cc" name="LHCInfoPerFillAnalyzer">
  <flags EDM_PLUGIN="1"/>
</library>
```

This unneccessarily confuses my BuildFile to CMake conversion tools, and
I think it would be better to not have duplicated plugin declarations in
general.
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42838/36968

  • This PR adds an extra 16KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

  • CondTools/RunInfo (db)

@perrotta, @cmsbuild, @consuegs, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test
(indeed: thank you @guitargeek )

@guitargeek
Copy link
Contributor Author

@perrotta, can this be approved for db? Thanks!

@perrotta
Copy link
Contributor

please abort

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1f0c1a/34921/summary.html
COMMIT: 7176cc0
CMSSW: CMSSW_13_3_X_2023-09-26-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42838/34921/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test CondToolsLHCInfoNewPopConTest had ERRORS

Comparison Summary

Summary:

  • You potentially added 24 lines to the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3358044
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3358007
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+db

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

merge

  • Failures are unrelated to this PR

@cmsbuild cmsbuild merged commit 56711f4 into cms-sw:master Sep 27, 2023
@guitargeek guitargeek deleted the buildfile_duplicate_entries_1 branch September 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants