Merge release/4.3.0 into main #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump version to 4.2.0 * Update sample CocoaPods projects * Move Checkout.podspec * Remove Carthage references from README * Update pods on CI * Fix the recommended usage in README * Rename PaymentViewController * Fix a failing test * Add CodeQL GitHub Actions workflow * Fix Checkout tests * Bump version to 4.2.1 * Update sample project versions to exact versions * Add workflow * Remove PR checks from Bitrise in favour of GitHub Actions * Add regression tests workflow * Update snapshots * PIMOB-XXXX: Using recommended resource_bundles in podspec to fix static linking (#452) Co-authored-by: Ehab Alsharkawy <[email protected]> * Add checkout logo (#462) * Remove regression tests from bitrise.yml (#463) * Add codeowners file (#464) * PIMOB-2041 Add app store validation (#465) This allows us to see if we cause any disruptions by our SDK that will prevent our merchants' builds to be uploaded to App Store successfully * Remove bitrise.yml since we now use GitHub Actions (#466) * Update README.md (#460) * Update README (#467) * Add workflows to publish Checkout and Frames pods (#468) * Add SwiftLint as a blocker pre-check for all the other checks (#469) SwiftLint comes pre-installed on runner images of GitHub. SwiftLint will run before all the other checks. If SwiftLint fails, then all the other checks don't run. SwiftLint only runs for the new files to avoid a big PR. It also parses errors and warnings for the new files and shows them on GitHub UI. * Fix the fixable SwiftLint issues (#471) * Fix the fixable SwiftLint issues * Remove --strict flag from SwiftLint step under check-pr workflow * Produce a line length linter error after 210 characters * Move some folders around and update README (#473) Move some folders around and update README * Add lint edited files script (#475) * Create deploy-github-pages.yml (#476) * Create deploy-github-pages.yml * Rename the workflow * Add generate-jazzy-docs.yml (#474) * Add only docs diff (#478) * Update jazzy docs (#477) * Remove docs from root folder (#479) * Update SnapshotTesting framework version (#480) We needed to define an exact version since they stopped supporting iOS 12 in a minor version release. This broke our CI/CD pipeline. * Trigger regression and validation workflows via labels (#481) * Update the PR template (#483) * Feature/partial readmes (#482) * Create sub README files * Set README refs to main branch * Update jazzy docs (#484) Co-authored-by: runner <[email protected]> * Update README (#488) --------- Co-authored-by: cko-developer-portal[bot] <89167155+cko-developer-portal[bot]@users.noreply.github.com> Co-authored-by: bartlomiejswierad-vodeno <[email protected]> Co-authored-by: Ehab Alsharkawy <[email protected]> Co-authored-by: runner <[email protected]>
* Add security code component * Add some unit tests * Add test cases for when the card scheme is not set * Add UI tests for the security code component * Hide linter warnings in GitHub UI * Address review comments
* Implement tokenisation * Add tokenisation UI tests * Add unit tests and refactor security code component * Add tests to CheckoutAPIServiceTests * Add regression tests * Fix high impact code smells * Address review comments * Update typealiases * Improve the sample page for the security code
* Implement logging for the security code component * Fix logging issue * Fix unit tests These two assertions have never been true when called independently. They were being asserted as true because the StubLogManager's static queue array was being populated by CardValidatorTests and was never being flushed. So, whenever the CheckoutTests are run altogether, tests were passing, but, whenever they are called separately, they were failing.
* Update security code component sample app * Update SPM reference branch
Resolve merge conflicts of main to develop PR
|
Kudos, SonarCloud Quality Gate passed!
|
okhan-okbay-cko
had a problem deploying
to
AppStoreValidation
GitHub Actions
Error
okhan-okbay-cko
added
Run Regression Tests
Validate For App Store
and removed
Run Regression Tests
Validate For App Store
labels
okhan-okbay-cko
temporarily deployed
to
AppStoreValidation
GitHub Actions
Inactive
chintan-soni-cko
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
LGTM. Few suggestions/silly questions. @okhan-okbay-cko
- Can we to link the release ticket in PR for release? Something we are doing in Android Reference
- Do we need to update Jazzy docs from here or it is the final step from the main branch? In Android, we are creating kdocs in the release PR itself
- Do we need to update the changelog in IOS? I have seen for last Release version
|
Hey @chintan-soni-cko, all are great questions, thanks for the detailed review 🙂
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge latest release changes into main.
Release 4.3.0