Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMOB-2041 App Store Validate - Automated #465

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

okhan-okbay-cko
Copy link
Contributor

@okhan-okbay-cko okhan-okbay-cko commented Sep 7, 2023

App Store Validation:

  • We needed a way to validate a sample app of ours, before anytime we merge a code into main (this is dictated via branch protection rulesets), to see that we don't break anything for our merchants.
  • workflow-dispatch triggered workflows don't run before they are merged into the default branch. Hence, I made it to be triggered by a PR action and the successful validation can be seen here.
  • Before the merge, we will disable the Validate For App Store requirement for a moment and then will re-introduce it immediately via branch protection rules.

This was previously developed and was in use but then became out of date. Details can be found here.

The other script that's called push.sh was deleted as well since it'll be a part of the incoming automated pod release GitHub Action workflow.

@okhan-okbay-cko okhan-okbay-cko temporarily deployed to AppStoreValidation September 7, 2023 16:49 — with GitHub Actions Inactive
@okhan-okbay-cko okhan-okbay-cko force-pushed the update/PIMOB-2041-app-store-validate-gha branch 2 times, most recently from b428fe0 to 4499fd2 Compare September 7, 2023 17:04
This allows us to see if we cause any disruptions
by our SDK that will prevent our merchants' builds
to be uploaded to App Store successfully
@okhan-okbay-cko okhan-okbay-cko force-pushed the update/PIMOB-2041-app-store-validate-gha branch from 7464751 to 9140356 Compare September 7, 2023 17:07
@okhan-okbay-cko okhan-okbay-cko changed the title Update/pimob 2041 app store validate gha PIMOB-2041 App Store Validate - Automated Sep 7, 2023
@okhan-okbay-cko okhan-okbay-cko merged commit fb93e1c into main Sep 8, 2023
@okhan-okbay-cko okhan-okbay-cko deleted the update/PIMOB-2041-app-store-validate-gha branch September 8, 2023 11:47
okhan-okbay-cko added a commit that referenced this pull request Oct 26, 2023
* Bump version to 4.2.0

* Update sample CocoaPods projects

* Move Checkout.podspec

* Remove Carthage references from README

* Update pods on CI

* Fix the recommended usage in  README

* Rename PaymentViewController

* Fix a failing test

* Add CodeQL GitHub Actions workflow

* Fix Checkout tests

* Bump version to 4.2.1

* Update sample project versions to exact versions

* Add workflow

* Remove PR checks from Bitrise in favour of GitHub Actions

* Add regression tests workflow

* Update snapshots

* PIMOB-XXXX: Using recommended resource_bundles in podspec to fix static linking (#452)

Co-authored-by: Ehab Alsharkawy <[email protected]>

* Add checkout logo (#462)

* Remove regression tests from bitrise.yml (#463)

* Add codeowners file (#464)

* PIMOB-2041 Add app store validation (#465)

This allows us to see if we cause any disruptions
by our SDK that will prevent our merchants' builds
to be uploaded to App Store successfully

* Remove bitrise.yml since we now use GitHub Actions (#466)

* Update README.md (#460)

* Update README (#467)

* Add workflows to publish Checkout and Frames pods (#468)

* Add SwiftLint as a blocker pre-check for all the other checks (#469)

SwiftLint comes pre-installed on runner images of GitHub.
SwiftLint will run before all the other checks.
If SwiftLint fails, then all the other checks don't run.
SwiftLint only runs for the new files to avoid a big PR.
It also parses errors and warnings for the new files and shows them on GitHub UI.

* Fix the fixable SwiftLint issues (#471)

* Fix the fixable SwiftLint issues

* Remove --strict flag from SwiftLint step under check-pr workflow

* Produce a line length linter error after 210 characters

* Move some folders around and update README (#473)

Move some folders around and update README

* Add lint edited files script (#475)

* Create deploy-github-pages.yml (#476)

* Create deploy-github-pages.yml

* Rename the workflow

* Add generate-jazzy-docs.yml (#474)

* Add only docs diff (#478)

* Update jazzy docs (#477)

* Remove docs from root folder (#479)

* Update SnapshotTesting framework version (#480)

We needed to define an exact version since they stopped supporting iOS 12
in a minor version release. This broke our CI/CD pipeline.

* Trigger regression and validation workflows via labels (#481)

* Update the PR template (#483)

* Feature/partial readmes (#482)

* Create sub README files

* Set README refs to main branch

* Update jazzy docs (#484)

Co-authored-by: runner <[email protected]>

* Update README (#488)

---------

Co-authored-by: cko-developer-portal[bot] <89167155+cko-developer-portal[bot]@users.noreply.github.com>
Co-authored-by: bartlomiejswierad-vodeno <[email protected]>
Co-authored-by: Ehab Alsharkawy <[email protected]>
Co-authored-by: runner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants