Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger regression and validation workflows via labels #481

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

okhan-okbay-cko
Copy link
Contributor

@okhan-okbay-cko okhan-okbay-cko commented Sep 20, 2023

Run Regression Tests and Validate App Store was added as requirements for all the PRs that target the main branch. I hoped that we could manually run those two workflows and satisfy the PR requirements. But, PR status checks don't get updated even after those workflows succeed, if they are triggered manually. So, the only way to make it work is to trigger them via PR labels.

I also left manual run capability in place, we can use it if need be.

@okhan-okbay-cko okhan-okbay-cko temporarily deployed to AppStoreValidation September 20, 2023 11:55 — with GitHub Actions Inactive
@okhan-okbay-cko okhan-okbay-cko temporarily deployed to AppStoreValidation September 20, 2023 12:00 — with GitHub Actions Inactive
@okhan-okbay-cko okhan-okbay-cko force-pushed the feature/label-trigger-gha branch from b9ec489 to f53e432 Compare September 20, 2023 12:06
@okhan-okbay-cko okhan-okbay-cko force-pushed the feature/label-trigger-gha branch from f53e432 to c0dd5d0 Compare September 20, 2023 12:11
@okhan-okbay-cko okhan-okbay-cko temporarily deployed to AppStoreValidation September 20, 2023 12:12 — with GitHub Actions Inactive
@okhan-okbay-cko okhan-okbay-cko force-pushed the feature/label-trigger-gha branch from c0dd5d0 to d8c6023 Compare September 20, 2023 12:22
@okhan-okbay-cko okhan-okbay-cko temporarily deployed to AppStoreValidation September 20, 2023 12:23 — with GitHub Actions Inactive
@okhan-okbay-cko okhan-okbay-cko merged commit 6ad010f into main Sep 20, 2023
@okhan-okbay-cko okhan-okbay-cko deleted the feature/label-trigger-gha branch September 20, 2023 13:12
okhan-okbay-cko added a commit that referenced this pull request Oct 26, 2023
* Bump version to 4.2.0

* Update sample CocoaPods projects

* Move Checkout.podspec

* Remove Carthage references from README

* Update pods on CI

* Fix the recommended usage in  README

* Rename PaymentViewController

* Fix a failing test

* Add CodeQL GitHub Actions workflow

* Fix Checkout tests

* Bump version to 4.2.1

* Update sample project versions to exact versions

* Add workflow

* Remove PR checks from Bitrise in favour of GitHub Actions

* Add regression tests workflow

* Update snapshots

* PIMOB-XXXX: Using recommended resource_bundles in podspec to fix static linking (#452)

Co-authored-by: Ehab Alsharkawy <[email protected]>

* Add checkout logo (#462)

* Remove regression tests from bitrise.yml (#463)

* Add codeowners file (#464)

* PIMOB-2041 Add app store validation (#465)

This allows us to see if we cause any disruptions
by our SDK that will prevent our merchants' builds
to be uploaded to App Store successfully

* Remove bitrise.yml since we now use GitHub Actions (#466)

* Update README.md (#460)

* Update README (#467)

* Add workflows to publish Checkout and Frames pods (#468)

* Add SwiftLint as a blocker pre-check for all the other checks (#469)

SwiftLint comes pre-installed on runner images of GitHub.
SwiftLint will run before all the other checks.
If SwiftLint fails, then all the other checks don't run.
SwiftLint only runs for the new files to avoid a big PR.
It also parses errors and warnings for the new files and shows them on GitHub UI.

* Fix the fixable SwiftLint issues (#471)

* Fix the fixable SwiftLint issues

* Remove --strict flag from SwiftLint step under check-pr workflow

* Produce a line length linter error after 210 characters

* Move some folders around and update README (#473)

Move some folders around and update README

* Add lint edited files script (#475)

* Create deploy-github-pages.yml (#476)

* Create deploy-github-pages.yml

* Rename the workflow

* Add generate-jazzy-docs.yml (#474)

* Add only docs diff (#478)

* Update jazzy docs (#477)

* Remove docs from root folder (#479)

* Update SnapshotTesting framework version (#480)

We needed to define an exact version since they stopped supporting iOS 12
in a minor version release. This broke our CI/CD pipeline.

* Trigger regression and validation workflows via labels (#481)

* Update the PR template (#483)

* Feature/partial readmes (#482)

* Create sub README files

* Set README refs to main branch

* Update jazzy docs (#484)

Co-authored-by: runner <[email protected]>

* Update README (#488)

---------

Co-authored-by: cko-developer-portal[bot] <89167155+cko-developer-portal[bot]@users.noreply.github.com>
Co-authored-by: bartlomiejswierad-vodeno <[email protected]>
Co-authored-by: Ehab Alsharkawy <[email protected]>
Co-authored-by: runner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants