-
Notifications
You must be signed in to change notification settings - Fork 48
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Sync develop branch with main (#491)
* Bump version to 4.2.0 * Update sample CocoaPods projects * Move Checkout.podspec * Remove Carthage references from README * Update pods on CI * Fix the recommended usage in README * Rename PaymentViewController * Fix a failing test * Add CodeQL GitHub Actions workflow * Fix Checkout tests * Bump version to 4.2.1 * Update sample project versions to exact versions * Add workflow * Remove PR checks from Bitrise in favour of GitHub Actions * Add regression tests workflow * Update snapshots * PIMOB-XXXX: Using recommended resource_bundles in podspec to fix static linking (#452) Co-authored-by: Ehab Alsharkawy <[email protected]> * Add checkout logo (#462) * Remove regression tests from bitrise.yml (#463) * Add codeowners file (#464) * PIMOB-2041 Add app store validation (#465) This allows us to see if we cause any disruptions by our SDK that will prevent our merchants' builds to be uploaded to App Store successfully * Remove bitrise.yml since we now use GitHub Actions (#466) * Update README.md (#460) * Update README (#467) * Add workflows to publish Checkout and Frames pods (#468) * Add SwiftLint as a blocker pre-check for all the other checks (#469) SwiftLint comes pre-installed on runner images of GitHub. SwiftLint will run before all the other checks. If SwiftLint fails, then all the other checks don't run. SwiftLint only runs for the new files to avoid a big PR. It also parses errors and warnings for the new files and shows them on GitHub UI. * Fix the fixable SwiftLint issues (#471) * Fix the fixable SwiftLint issues * Remove --strict flag from SwiftLint step under check-pr workflow * Produce a line length linter error after 210 characters * Move some folders around and update README (#473) Move some folders around and update README * Add lint edited files script (#475) * Create deploy-github-pages.yml (#476) * Create deploy-github-pages.yml * Rename the workflow * Add generate-jazzy-docs.yml (#474) * Add only docs diff (#478) * Update jazzy docs (#477) * Remove docs from root folder (#479) * Update SnapshotTesting framework version (#480) We needed to define an exact version since they stopped supporting iOS 12 in a minor version release. This broke our CI/CD pipeline. * Trigger regression and validation workflows via labels (#481) * Update the PR template (#483) * Feature/partial readmes (#482) * Create sub README files * Set README refs to main branch * Update jazzy docs (#484) Co-authored-by: runner <[email protected]> * Update README (#488) --------- Co-authored-by: cko-developer-portal[bot] <89167155+cko-developer-portal[bot]@users.noreply.github.com> Co-authored-by: bartlomiejswierad-vodeno <[email protected]> Co-authored-by: Ehab Alsharkawy <[email protected]> Co-authored-by: runner <[email protected]>
- Loading branch information
5 people
authored
Oct 26, 2023
1 parent
b99570e
commit 76d9940
Showing
402 changed files
with
6,192 additions
and
6,773 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # The iOS mobile team owns and maintains this project. | ||
| * @checkout/mobile-ios |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,30 @@ | ||
| ## Issue | ||
|
|
||
| _Issue ticket number and link._ | ||
|
|
||
| ## Proposed changes | ||
|
|
||
| Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. | ||
| _Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue._ | ||
|
|
||
| ## Types of changes | ||
| ## Test Steps | ||
|
|
||
| What types of changes does your code introduce to Frames Ios? | ||
| _Put an `x` in the boxes that apply_ | ||
| _If there's any functionality change, please list a step by step guide of how to verify the changes, and/or upload a screen recording for any visible changes._ | ||
|
|
||
| * [ ] Bugfix (non-breaking change which fixes an issue) | ||
| * [ ] New feature (non-breaking change which adds functionality) | ||
| * [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) | ||
| > For instance: | ||
| > 1. Go to the main screen | ||
| > 2. Tap on primary button | ||
| > 3. Verify the image is shown on the screen | ||
| ## Checklist | ||
|
|
||
| _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ | ||
|
|
||
| * [ ] Reviewers assigned | ||
| * [ ] I have performed a self-review of my code and manual testing | ||
| * [ ] Lint and unit tests pass locally with my changes | ||
| * [ ] I have added tests that prove my fix is effective or that my feature works | ||
| * [ ] I have added necessary documentation (if appropriate) | ||
| * [ ] I have added necessary documentation (if applicable) | ||
|
|
||
| ## Further comments | ||
|
|
||
| If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... | ||
| _If this is a relatively large or complex change, kick off the discussion by explaining why you choose the solution you did and what alternatives you considered, etc..._ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.