Implement security code component UI #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS Example Frame/iOS Example Frame/ViewController/SecurityCodeViewController.swift
Outdated
Show resolved
Hide resolved
Source/UI/SecurityCodeComponent/SecurityCodeComponentConfiguration.swift
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
okhan-okbay-cko
force-pushed
the
feature/cvv-component
branch
8 times, most recently
from
07b4f7b to
0b349fd
Compare
okhan-okbay-cko
requested review from
deepesh-vasthimal-cko and
chintan-soni-cko
okhan-okbay-cko
force-pushed
the
feature/cvv-component
branch
4 times, most recently
from
e752d4c to
b45fc8d
Compare
okhan-okbay-cko
had a problem deploying
to
AppStoreValidation
GitHub Actions
Error
okhan-okbay-cko
temporarily deployed
to
AppStoreValidation
GitHub Actions
Inactive
okhan-okbay-cko
commented
Oct 24, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Comments are addressed. Please have another look @deepesh-vasthimal-cko |
deepesh-vasthimal-cko
previously approved these changes
Oct 26, 2023
okhan-okbay-cko
force-pushed
the
feature/cvv-component
branch
from
702028f to
5ccc783
Compare
okhan-okbay-cko
dismissed
deepesh-vasthimal-cko’s stale review
The base branch was changed.
okhan-okbay-cko
force-pushed
the
feature/cvv-component
branch
from
5ccc783 to
674b102
Compare
okhan-okbay-cko
added a commit
that referenced
this pull request
Nov 3, 2023
* Add security code component * Add some unit tests * Add test cases for when the card scheme is not set * Add UI tests for the security code component * Hide linter warnings in GitHub UI * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
JIRA-2167
Proposed changes
Add Security Code Component UI.
Test Steps
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Just having a set of basic UITests felt enough. No need for detailed regression tests. If you see some scenarios that'd do well with extensive regression tests being written upon, please add a comment to this PR.