Implement logging for the security code component #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhan-okbay-cko
requested review from
deepesh-vasthimal-cko,
patrick-hoban-cko and
chintan-soni-cko
deepesh-vasthimal-cko
previously approved these changes
Nov 1, 2023
okhan-okbay-cko
force-pushed
the
feature/cvv-component-tokenisation
branch
from
43fd866 to
3484a8f
Compare
Base automatically changed from
feature/cvv-component-tokenisation
to
develop
November 2, 2023 13:34
okhan-okbay-cko
dismissed
deepesh-vasthimal-cko’s stale review
The base branch was changed.
okhan-okbay-cko
force-pushed
the
feature/cvv-component-logging
branch
from
e5ac3e0 to
b10261c
Compare
patrick-hoban-cko
previously approved these changes
Nov 2, 2023
|
Validated logs. LGTM |
deepesh-vasthimal-cko
previously approved these changes
Nov 2, 2023
These two assertions have never been true when called independently. They were being asserted as true because the SturLogManager's static queue array was being populated by CardValidatorTests and was never being flushed. So, whenever the CheckoutTests are run altogether, tests were passing, but, whenever they are called separately, they were failing.
okhan-okbay-cko
dismissed stale reviews from deepesh-vasthimal-cko, patrick-hoban-cko, and chintan-soni-cko
via
c8d8b62
|
Kudos, SonarCloud Quality Gate passed!
|
patrick-hoban-cko
approved these changes
Nov 2, 2023
okhan-okbay-cko
added a commit
that referenced
this pull request
Nov 3, 2023
* Implement logging for the security code component * Fix logging issue * Fix unit tests These two assertions have never been true when called independently. They were being asserted as true because the StubLogManager's static queue array was being populated by CardValidatorTests and was never being flushed. So, whenever the CheckoutTests are run altogether, tests were passing, but, whenever they are called separately, they were failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
JIRA-2169
Proposed changes
Log the token requested and response events for the newly introduced security code component
Test Steps
If there's any functionality change, please list a step by step guide of how to verify the changes, and/or upload a screen recording for any visible changes.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Token requested success log is here
Token response success log is here
Server error log is here