Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems with Stretch properties #96

Open
mapedorr opened this issue Oct 16, 2023 · 3 comments
Open

Problems with Stretch properties #96

mapedorr opened this issue Oct 16, 2023 · 3 comments
Assignees
@mapedorr
Labels
bug Something isn't working
Milestone
v2.1 - Stable

Comments

@mapedorr
Copy link
Collaborator

What's Wrong

When configuring the Stretch properties (display/window/stretch/mode and display/window/stretch/aspect), the prop images do not behave as they should compared to a project that doesn't use Popochiu.

  1. Popochiu should not override this configuration (setup.gd:133, setup.gd:134).

image

  1. The cause of the problem needs to be identified (it might be something in the camera settings).

Evidence

The gray bar on the left should not be visible if display/window/stretch/aspect is set to expand.

image

Expected Behavior

The center of the image should always be visible, showing more or less of it as the game window's width changes.

image

image
@mapedorr mapedorr added the bug Something isn't working label Oct 16, 2023
@mapedorr mapedorr added this to the v2.0 - alpha 3 milestone Oct 16, 2023
@mapedorr mapedorr self-assigned this Oct 16, 2023
mapedorr added a commit that referenced this issue Oct 22, 2023
@mapedorr
Fix node selection, pitch and stretch setup
4b1317e 
fix: #89 by using `get_pitch_scale` instead of defining a get method for
the `pitch` property.
fix: #80 by changing the way `popochiu_plugin.gd` selects the
WalkToHelper and Baseline nodes.
fix: part of #96 by not overriding the setup made in the project
settings regarding those properties unless the game type is set to
"Pixel".
@mapedorr
Copy link
Collaborator Author

This is related with how Popochiu sets limit to the camera based on the viewport size of the project.

An idea is that could change this by not limiting the camera using its properties but by code. We'll have to research which will be the best approach.

@mapedorr
Copy link
Collaborator Author

In 4b1317e I made a change so the plugin doesn't override the configuration made by the developer in the project_settings. Still need to check how to handle this since it is related to the limits we are setting to the main camera, which are like they are to make it behave as expected (in terms of following the PC). I'll try to update this for beta 1 or 2.

@mapedorr mapedorr mentioned this issue Oct 26, 2023
Merged
mapedorr added a commit that referenced this issue Oct 27, 2023
@mapedorr
Alpha 3 (#103)
ea21fe5 
* Fix node selection, pitch and stretch setup

fix: #89 by using `get_pitch_scale` instead of defining a get method for
the `pitch` property.
fix: #80 by changing the way `popochiu_plugin.gd` selects the
WalkToHelper and Baseline nodes.
fix: part of #96 by not overriding the setup made in the project
settings regarding those properties unless the game type is set to
"Pixel".

* Fix #79 and #81

Now deleting Popochiu objects directly in PopochiuRoom scene tree also
updates the rows in the Room tab.

* Fix: #88 and #99

upd: README and LEEME file with small icons and links to the currento
supported Godot versions for Popochiu 2 and the Discord server.
fix: Camera zoom was calling a typo method.
upd: New audio stream players are created during runtime if the system
runs out of them.

* Fix in extra row creation when adding room objects

fix: Selecting game display type working properly.
fix: WalkToHelper or BaselineHelper were keeping selected when selecting
another node.
fea: Added support for assigning an emotion when calling
`PopochiuCharacter.say(text: String, emotion: String)`. It also works
for `queue_say()`.

* Fix #82

The `graphic_interface` folder can be moved to `res://popochiu` without
bugs.
upd: remove all uses of `EditorInterface.edit_node()` by
`PopochiuUtils.select_node()`.

* upd: Replaced old `_now` suffix by `queue_` prefix

Added res://popochiu/ (game project) to .gitignore in order to avoid
conflicts on things related to the project each developer is working on.

* Change MOVING_ by LOOKING_ in PopochiuCharacter.FlipsWhen

* fix: dialog option ID no longer writing backwards

Removed not used connection and changed plugin version.
Updated version name with alpha suffix.

* Create release notes for Alpha 3

* Fix typo and update links in Fixes section
mapedorr added a commit that referenced this issue Oct 27, 2023
@mapedorr
Alpha 3 (#103)
37539d2 
* Fix node selection, pitch and stretch setup

fix: #89 by using `get_pitch_scale` instead of defining a get method for
the `pitch` property.
fix: #80 by changing the way `popochiu_plugin.gd` selects the
WalkToHelper and Baseline nodes.
fix: part of #96 by not overriding the setup made in the project
settings regarding those properties unless the game type is set to
"Pixel".

* Fix #79 and #81

Now deleting Popochiu objects directly in PopochiuRoom scene tree also
updates the rows in the Room tab.

* Fix: #88 and #99

upd: README and LEEME file with small icons and links to the currento
supported Godot versions for Popochiu 2 and the Discord server.
fix: Camera zoom was calling a typo method.
upd: New audio stream players are created during runtime if the system
runs out of them.

* Fix in extra row creation when adding room objects

fix: Selecting game display type working properly.
fix: WalkToHelper or BaselineHelper were keeping selected when selecting
another node.
fea: Added support for assigning an emotion when calling
`PopochiuCharacter.say(text: String, emotion: String)`. It also works
for `queue_say()`.

* Fix #82

The `graphic_interface` folder can be moved to `res://popochiu` without
bugs.
upd: remove all uses of `EditorInterface.edit_node()` by
`PopochiuUtils.select_node()`.

* upd: Replaced old `_now` suffix by `queue_` prefix

Added res://popochiu/ (game project) to .gitignore in order to avoid
conflicts on things related to the project each developer is working on.

* Change MOVING_ by LOOKING_ in PopochiuCharacter.FlipsWhen

* fix: dialog option ID no longer writing backwards

Removed not used connection and changed plugin version.
Updated version name with alpha suffix.

* Create release notes for Alpha 3

* Fix typo and update links in Fixes section
@stickgrinder
Copy link
Collaborator

Moved to 2.1 because solving this will require pretty impacting changes to how camera works.

@stickgrinder stickgrinder moved this to Backlog in Popochiu Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapedorr mapedorr

Labels
bug Something isn't working
Projects
Popochiu
Status: Backlog
Milestone
v2.1 - Stable
Development

No branches or pull requests
2 participants
@stickgrinder @mapedorr