Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot Idelete elements from the Popochiu dock #81

Closed
papernoise opened this issue Sep 25, 2023 · 2 comments
Closed

Cannot Idelete elements from the Popochiu dock #81

papernoise opened this issue Sep 25, 2023 · 2 comments
Assignees
@mapedorr
Labels
bug Something isn't working
Milestone
v2.0 - alpha 3

Comments

@papernoise
Copy link

Godot version: 4.1.1
Popochiu Version: 2.0 alpha
OS: Windows 11

How to reproduce:

Option 1

Click the "remove" button for a prop in the dock, but do not select the "delete folder" option
image

The prop is deleted from the scene
The prop is not deleted from the FileSystem
The prop is not deleted from the dock

This error message appears:

res://addons/popochiu/editor/main_dock/object_row/popochiu_object_row.gd:619 - Invalid get index 'dir' (on base: 'Panel (popochiu_dock.gd)').
  res://addons/popochiu/editor/main_dock/object_row/popochiu_object_row.gd:544 - Invalid get index 'dir' (on base: 'Panel (popochiu_dock.gd)').

Option 2

Click the "remove" button for a prop in the dock, and also select the "delete folder" option

same result as above, with the same error message

As a sidenote, after messing with this for some time, now my main room won't open anymore.

  scene/resources/resource_format_text.cpp:447 - res://popochiu/rooms/101/room_101.tscn:16 - ext_resource, invalid UID: uid://ccnnmtlgm5mx - using text path instead: res://popochiu/rooms/101/props/blue_square/prop_blue_square.tscn
  Cannot open file 'res://popochiu/rooms/101/props/blue_square/prop_blue_square.tscn'.
  Failed loading resource: res://popochiu/rooms/101/props/blue_square/prop_blue_square.tscn. Make sure resources have been imported by opening the project in the editor at least once.
  scene/resources/resource_format_text.cpp:283 - res://popochiu/rooms/101/room_101.tscn:107 - Parse Error: 
  Failed loading resource: res://popochiu/rooms/101/room_101.tscn. Make sure resources have been imported by opening the project in the editor at least once.
  Parent node is busy setting up children, `set_name(new_name)` failed. Consider using `set_name.call_deferred(new_name)` instead.
@papernoise
Copy link
Author

I should add that I had manually deleted the props from the scene, but it seems like the room scene is still looking for it.

@mapedorr mapedorr added the bug Something isn't working label Sep 26, 2023
@mapedorr mapedorr self-assigned this Oct 10, 2023
mapedorr added a commit that referenced this issue Oct 23, 2023
@mapedorr
Fix #79 and #81
136fea8 
Now deleting Popochiu objects directly in PopochiuRoom scene tree also
updates the rows in the Room tab.
@mapedorr
Copy link
Collaborator

Fixed in 136fea8. And added a functionality that will also remove the rows in the Room tab when deleting nodes directly in the scene tree.

@mapedorr mapedorr mentioned this issue Oct 26, 2023
Merged
mapedorr added a commit that referenced this issue Oct 27, 2023
@mapedorr
Alpha 3 (#103)
ea21fe5 
* Fix node selection, pitch and stretch setup

fix: #89 by using `get_pitch_scale` instead of defining a get method for
the `pitch` property.
fix: #80 by changing the way `popochiu_plugin.gd` selects the
WalkToHelper and Baseline nodes.
fix: part of #96 by not overriding the setup made in the project
settings regarding those properties unless the game type is set to
"Pixel".

* Fix #79 and #81

Now deleting Popochiu objects directly in PopochiuRoom scene tree also
updates the rows in the Room tab.

* Fix: #88 and #99

upd: README and LEEME file with small icons and links to the currento
supported Godot versions for Popochiu 2 and the Discord server.
fix: Camera zoom was calling a typo method.
upd: New audio stream players are created during runtime if the system
runs out of them.

* Fix in extra row creation when adding room objects

fix: Selecting game display type working properly.
fix: WalkToHelper or BaselineHelper were keeping selected when selecting
another node.
fea: Added support for assigning an emotion when calling
`PopochiuCharacter.say(text: String, emotion: String)`. It also works
for `queue_say()`.

* Fix #82

The `graphic_interface` folder can be moved to `res://popochiu` without
bugs.
upd: remove all uses of `EditorInterface.edit_node()` by
`PopochiuUtils.select_node()`.

* upd: Replaced old `_now` suffix by `queue_` prefix

Added res://popochiu/ (game project) to .gitignore in order to avoid
conflicts on things related to the project each developer is working on.

* Change MOVING_ by LOOKING_ in PopochiuCharacter.FlipsWhen

* fix: dialog option ID no longer writing backwards

Removed not used connection and changed plugin version.
Updated version name with alpha suffix.

* Create release notes for Alpha 3

* Fix typo and update links in Fixes section
mapedorr added a commit that referenced this issue Oct 27, 2023
@mapedorr
Alpha 3 (#103)
37539d2 
* Fix node selection, pitch and stretch setup

fix: #89 by using `get_pitch_scale` instead of defining a get method for
the `pitch` property.
fix: #80 by changing the way `popochiu_plugin.gd` selects the
WalkToHelper and Baseline nodes.
fix: part of #96 by not overriding the setup made in the project
settings regarding those properties unless the game type is set to
"Pixel".

* Fix #79 and #81

Now deleting Popochiu objects directly in PopochiuRoom scene tree also
updates the rows in the Room tab.

* Fix: #88 and #99

upd: README and LEEME file with small icons and links to the currento
supported Godot versions for Popochiu 2 and the Discord server.
fix: Camera zoom was calling a typo method.
upd: New audio stream players are created during runtime if the system
runs out of them.

* Fix in extra row creation when adding room objects

fix: Selecting game display type working properly.
fix: WalkToHelper or BaselineHelper were keeping selected when selecting
another node.
fea: Added support for assigning an emotion when calling
`PopochiuCharacter.say(text: String, emotion: String)`. It also works
for `queue_say()`.

* Fix #82

The `graphic_interface` folder can be moved to `res://popochiu` without
bugs.
upd: remove all uses of `EditorInterface.edit_node()` by
`PopochiuUtils.select_node()`.

* upd: Replaced old `_now` suffix by `queue_` prefix

Added res://popochiu/ (game project) to .gitignore in order to avoid
conflicts on things related to the project each developer is working on.

* Change MOVING_ by LOOKING_ in PopochiuCharacter.FlipsWhen

* fix: dialog option ID no longer writing backwards

Removed not used connection and changed plugin version.
Updated version name with alpha suffix.

* Create release notes for Alpha 3

* Fix typo and update links in Fixes section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapedorr mapedorr

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0 - alpha 3
Development

No branches or pull requests
2 participants
@papernoise @mapedorr