Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with playing multiple sound effects #88

Closed
papernoise opened this issue Oct 6, 2023 · 1 comment
Closed

Issues with playing multiple sound effects #88

papernoise opened this issue Oct 6, 2023 · 1 comment
Assignees
@mapedorr
Labels
bug Something isn't working
Milestone
v2.0 - alpha 3

Comments

@papernoise
Copy link

Godot: 4.1.2
Popochiu: 2.0 (latest version from 2.0 branch)

How to reproduce:

  • add code to multiple props to play sound effects
  • test the game and click the props so the sounds play overlapping each other
  • Debugger shows error messages
  • the issue does not appear when playing sfx on top of music, haven't tested with voices or UI sounds.

These are the errors:

E 0:00:07:0836 audio_manager.gd:229 @ _play(): Signal 'finished' is already connected to given callable 'Node(audio_manager.gd)::_make_available' in that object.
<C++ Error> Method/function failed. Returning: ERR_INVALID_PARAMETER
<C++ Source> core/object/object.cpp:1294 @ connect()
audio_manager.gd:229 @ _play()
audio_manager.gd:56 @ play_sound_cue()
audio_cue_sound.gd:15 @ play()
prop_cred_anta_dx.gd:16 @ _on_click()
popochiu_clickable.gd:64 @ _unhandled_input()
@mapedorr mapedorr self-assigned this Oct 10, 2023
@mapedorr mapedorr added the bug Something isn't working label Oct 10, 2023
@mapedorr mapedorr added this to the v2.0 - alpha 3 milestone Oct 10, 2023
@mapedorr mapedorr mentioned this issue Oct 24, 2023
Closed
mapedorr added a commit that referenced this issue Oct 24, 2023
@mapedorr
Fix: #88 and #99
88044a2 
upd: README and LEEME file with small icons and links to the currento
supported Godot versions for Popochiu 2 and the Discord server.
fix: Camera zoom was calling a typo method.
upd: New audio stream players are created during runtime if the system
runs out of them.
@mapedorr
Copy link
Collaborator

Fixed in 88044a2. Now new AudioStreamPlayer (or AudioStreamPlayer2D) are created when the system runs out of players (that is when all the created players by default are in use).

@mapedorr mapedorr mentioned this issue Oct 26, 2023
Merged
mapedorr added a commit that referenced this issue Oct 27, 2023
@mapedorr
Alpha 3 (#103)
ea21fe5 
* Fix node selection, pitch and stretch setup

fix: #89 by using `get_pitch_scale` instead of defining a get method for
the `pitch` property.
fix: #80 by changing the way `popochiu_plugin.gd` selects the
WalkToHelper and Baseline nodes.
fix: part of #96 by not overriding the setup made in the project
settings regarding those properties unless the game type is set to
"Pixel".

* Fix #79 and #81

Now deleting Popochiu objects directly in PopochiuRoom scene tree also
updates the rows in the Room tab.

* Fix: #88 and #99

upd: README and LEEME file with small icons and links to the currento
supported Godot versions for Popochiu 2 and the Discord server.
fix: Camera zoom was calling a typo method.
upd: New audio stream players are created during runtime if the system
runs out of them.

* Fix in extra row creation when adding room objects

fix: Selecting game display type working properly.
fix: WalkToHelper or BaselineHelper were keeping selected when selecting
another node.
fea: Added support for assigning an emotion when calling
`PopochiuCharacter.say(text: String, emotion: String)`. It also works
for `queue_say()`.

* Fix #82

The `graphic_interface` folder can be moved to `res://popochiu` without
bugs.
upd: remove all uses of `EditorInterface.edit_node()` by
`PopochiuUtils.select_node()`.

* upd: Replaced old `_now` suffix by `queue_` prefix

Added res://popochiu/ (game project) to .gitignore in order to avoid
conflicts on things related to the project each developer is working on.

* Change MOVING_ by LOOKING_ in PopochiuCharacter.FlipsWhen

* fix: dialog option ID no longer writing backwards

Removed not used connection and changed plugin version.
Updated version name with alpha suffix.

* Create release notes for Alpha 3

* Fix typo and update links in Fixes section
mapedorr added a commit that referenced this issue Oct 27, 2023
@mapedorr
Alpha 3 (#103)
37539d2 
* Fix node selection, pitch and stretch setup

fix: #89 by using `get_pitch_scale` instead of defining a get method for
the `pitch` property.
fix: #80 by changing the way `popochiu_plugin.gd` selects the
WalkToHelper and Baseline nodes.
fix: part of #96 by not overriding the setup made in the project
settings regarding those properties unless the game type is set to
"Pixel".

* Fix #79 and #81

Now deleting Popochiu objects directly in PopochiuRoom scene tree also
updates the rows in the Room tab.

* Fix: #88 and #99

upd: README and LEEME file with small icons and links to the currento
supported Godot versions for Popochiu 2 and the Discord server.
fix: Camera zoom was calling a typo method.
upd: New audio stream players are created during runtime if the system
runs out of them.

* Fix in extra row creation when adding room objects

fix: Selecting game display type working properly.
fix: WalkToHelper or BaselineHelper were keeping selected when selecting
another node.
fea: Added support for assigning an emotion when calling
`PopochiuCharacter.say(text: String, emotion: String)`. It also works
for `queue_say()`.

* Fix #82

The `graphic_interface` folder can be moved to `res://popochiu` without
bugs.
upd: remove all uses of `EditorInterface.edit_node()` by
`PopochiuUtils.select_node()`.

* upd: Replaced old `_now` suffix by `queue_` prefix

Added res://popochiu/ (game project) to .gitignore in order to avoid
conflicts on things related to the project each developer is working on.

* Change MOVING_ by LOOKING_ in PopochiuCharacter.FlipsWhen

* fix: dialog option ID no longer writing backwards

Removed not used connection and changed plugin version.
Updated version name with alpha suffix.

* Create release notes for Alpha 3

* Fix typo and update links in Fixes section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mapedorr mapedorr

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0 - alpha 3
Development

No branches or pull requests
2 participants
@papernoise @mapedorr