Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve starting point of feed when tapping on Load new content #22182

Closed
kjozwiak opened this issue Apr 8, 2022 · 3 comments · Fixed by brave/brave-core#13155
Closed

improve starting point of feed when tapping on Load new content #22182

kjozwiak opened this issue Apr 8, 2022 · 3 comments · Fixed by brave/brave-core#13155

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

Description

This is another follow up to #20408 & #21403 to improve the behaviour of Brave News when tapping on the Load new content button after enabling/disabling news sources via Settings.

Currently, when you tap Load new content on a phone, it will refresh the feed and move the user to the top. However, rather than moving the view right where the feed starts, we're also displaying a large area of the NTP which is blank. We should follow the same behaviour that iOS in terms of starting at the beginning of the feed without any dead space.

Steps to reproduce

  1. Install Brave and enable Brave News via Settings
  2. once enabled, scroll through the feed and select the Brave News Settings hamburger menu
  3. enable several random news feeds and back to Brave News by pressing <-- (or close Settings using the X)
  4. tap on the Load new content button

Actual result

deadSpace

Expected result

Example of what it should look like on Android iOS Example
Screenshot_20220408-162039 IMG_3858

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6 (Phone)
  • Android version: Andriid 12

Brave version

1.39.42 Chromium: 100.0.4896.79

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @bsclifton @alexsafe @tapanmodh @anthonypkeane @brave/qa-team

@timchilds
Copy link

timchilds commented Apr 8, 2022

@kjozwiak I can reproduce this. I don't see as much NTP empty space on my Galaxy A51 (Android 11) vs. your device.

@alexsafe @tapanmodh we should try to improve this after the scrolling velocity is fixed.

Screen_Recording_20220408-143127_Brave.-.Nightly.mp4

@kjozwiak
Copy link
Member Author

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.38.118 Chromium: 101.0.4951.67 (Official Build) (64-bit)
--- | ---
Revision | 8888ee7a24e2c36661ddb9536c35b7d4852a3a98-refs/branch-heads/4951@{#1230}
OS | Android 12; Build/SP1A.210812.016

Went through the STR/Cases outlined via #22182 (comment) and ensured that the large gap between the NTP and the first news card isn't appearing once Load new content as been tapped. Also see #22183 for more examples of the above working as expected.

Screenshot_20220516-001956_Brave

@kjozwiak
Copy link
Member Author

Going to use #22183 for release notes which is basically the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants