Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up #20408] Fix Load new content behaviour correctly #21403

Closed
srirambv opened this issue Mar 2, 2022 · 4 comments · Fixed by brave/brave-core#12852
Closed

[Follow up #20408] Fix Load new content behaviour correctly #21403

srirambv opened this issue Mar 2, 2022 · 4 comments · Fixed by brave/brave-core#12852
Assignees
Labels
android-phone-specific bug feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 2, 2022

Description

[Follow up #20408] Fix Load new content behaviour correctly

Steps to reproduce

  1. Follow steps from Load new content hides Brave News feed  #20408

Actual result

Tablet Mobile
20408-Tab.mp4
20408_gs21.mp4

Expected result

Jump to the top of feed but still show it

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes with 1.36.x
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.36.x onward

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @alexsafe @mattmcalister @Uni-verse

@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

@tapanmodh technically this should still be in the 1.39.x milestone as the original PR landed in 1.39.x and this wasn't uplifted yet. Once brave/brave-core#12931 is merged into 1.38.x, the release team will move the issue into the correct milestone, in this case, 1.38.x. You can view/read the process via https://github.com/brave/brave-browser/wiki/Triage-Guidelines#uplifting.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

So as per the above, I created #22182 and #22183 as follow ups. The fix from brave/brave-core#12852 has improved things on the phones but still seems broken on the tablet as per #22183.

@brave/qa-team keep in mind the above when verifying the above issue. Going to label this as android-phone-specific as brave/brave-core#12852 didn't fix the tablet case. That will need to be fixed via #22183.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

Above requires 1.38.87 or higher for 1.38.x verification.

@Uni-verse
Copy link
Contributor

Verified using 1.38.103, Chromium 100.0.4896.127 on Samsung GS21 running Android 12

  • Ensured Load new content will bring user to the top of news feed
21403_2.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-phone-specific bug feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants