Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New content behaviour fix android (uplift to 1.39.x) #13162

Closed
wants to merge 6 commits into from
Closed

New content behaviour fix android (uplift to 1.39.x) #13162

wants to merge 6 commits into from

Conversation

tapanmodh
Copy link
Contributor

@tapanmodh tapanmodh commented Apr 25, 2022 •
edited
Loading

Fixes brave/brave-browser#22182
Fixes brave/brave-browser#22183
Fixes brave/brave-browser#22356
Uplift of #13155

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tapanmodh tapanmodh added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 25, 2022
@tapanmodh tapanmodh added this to the 1.39.x - Beta milestone Apr 25, 2022
@tapanmodh tapanmodh self-assigned this Apr 25, 2022
SergeyZhukovsky
SergeyZhukovsky reviewed Apr 26, 2022
View reviewed changes
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java
SharedPreferencesManager.getInstance().writeInt(
BRAVE_NESTED_SCROLLVIEW_POSITION
+ BraveActivity.getBraveActivity()
.getActivityTab()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to check tab on null? as we do check in the code above.

SergeyZhukovsky
SergeyZhukovsky reviewed Apr 26, 2022
View reviewed changes
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java
SharedPreferencesManager.getInstance().writeInt(
"position_"
+ BraveActivity.getBraveActivity()
.getActivityTab()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same about null

SergeyZhukovsky
SergeyZhukovsky reviewed Apr 26, 2022
View reviewed changes
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java
SharedPreferencesManager.getInstance().writeInt(
BRAVE_RECYCLERVIEW_POSITION
+ BraveActivity.getBraveActivity()
.getActivityTab()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same about null

SergeyZhukovsky
SergeyZhukovsky reviewed Apr 26, 2022
View reviewed changes
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java

SharedPreferencesManager.getInstance().writeInt("position_"
+ BraveActivity.getBraveActivity()
.getActivityTab()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null check?

SergeyZhukovsky
SergeyZhukovsky reviewed Apr 26, 2022
View reviewed changes
android/java/org/chromium/chrome/browser/ntp/BraveNewTabPageLayout.java
SharedPreferencesManager.getInstance().writeInt(
BRAVE_RECYCLERVIEW_POSITION
+ BraveActivity.getBraveActivity()
.getActivityTab()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null check?

@kjozwiak
Copy link
Member

Closing in favour of #13184.

@kjozwiak kjozwiak closed this Apr 28, 2022
@kjozwiak kjozwiak deleted the new_content_behaviour_fix_android_1.39.x branch April 28, 2022 19:41
@kjozwiak kjozwiak removed request for a team, deeppandya and alexsafe April 28, 2022 19:41
@kjozwiak kjozwiak removed CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 28, 2022
@kjozwiak kjozwiak removed CI/skip-windows CI/skip-ios Do not run CI builds for iOS labels Apr 28, 2022
@kjozwiak kjozwiak removed this from the 1.39.x - Beta milestone Apr 28, 2022
This was referenced Apr 28, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tapanmodh @kjozwiak @SergeyZhukovsky