Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntp fixed start position news feed android (uplift to 1.38.x) #13187

Merged
merged 3 commits into from
May 1, 2022
Merged

ntp fixed start position news feed android (uplift to 1.38.x) #13187

merged 3 commits into from
May 1, 2022

Conversation

tapanmodh
Copy link
Contributor

@tapanmodh tapanmodh commented Apr 27, 2022 •
edited by kjozwiak
Loading

Fixes brave/brave-browser#22182
Fixes brave/brave-browser#22183
Fixes brave/brave-browser#22356
Fixes brave/brave-browser#22549
Uplift of #13171
Uplift of #13155

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tapanmodh tapanmodh added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 27, 2022
@tapanmodh tapanmodh added this to the 1.38.x - Release #2 milestone Apr 27, 2022
@tapanmodh tapanmodh self-assigned this Apr 27, 2022
@kjozwiak
Copy link
Member

Double checked with @tapanmodh and ensured that the changes that @SergeyZhukovsky requested re: null checks via #13162 have been addressed.

@kjozwiak kjozwiak mentioned this pull request Apr 28, 2022
Closed
7 tasks
kjozwiak
kjozwiak approved these changes May 1, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.38.x approved 👍 QA has verified the PR on Nightly as per #13155 (comment) & #13171 (comment).

@kjozwiak kjozwiak merged commit c1e8f2b into 1.38.x May 1, 2022
@kjozwiak kjozwiak deleted the ntp_feed_position_fix_android_1.38.x branch May 1, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@deeppandya deeppandya Awaiting requested review from deeppandya

@alexsafe alexsafe Awaiting requested review from alexsafe

@brave-browser-releases brave-browser-releases Awaiting requested review from brave-browser-releases

Assignees

@tapanmodh tapanmodh

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.38.x - Release #6
Development

Successfully merging this pull request may close these issues.
3 participants
@tapanmodh @kjozwiak @LaurenWags