-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] News new content behaviour fix #13155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -888,11 +876,12 @@ private void initNews() { | |||
if (mActivity == null) { | |||
mActivity = BraveActivity.getBraveActivity(); | |||
} | |||
if (!ConfigurationUtils.isLandscape(mActivity) && prevScrollPosition > 1) { | |||
/*if (!ConfigurationUtils.isLandscape(mActivity) && prevScrollPosition > 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need commented out code here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed. I'll remove it
…ndroid [Android] News new content behaviour fix
…ndroid [Android] News new content behaviour fix
Verification PASSED on both
|
Resolves brave/brave-browser#22182
Resolves brave/brave-browser#22183
Resolves brave/brave-browser#22356
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: