-
Notifications
You must be signed in to change notification settings - Fork 63
Migrate typescript-eslint-parser to 21.0.2 #174
Migrate typescript-eslint-parser to 21.0.2 #174
Conversation
3ca9a1c
to
2cc53bd
Compare
This looks so much cleaner... thank you @armano2 . |
@weirdpattern big part of additionally i found some issues in this and old version, any keyword is not always catched, due to visitor and its listed eslint/typescript-eslint-parser#555 class Foo<T extends any = any> extends Foo<any> {} non of them is going to be reported |
I should go through and read up on the new nodes. |
@bradzacher @weirdpattern for everyone who wants to try new version i suggest to use npm/@armano/typescript-eslint-parser i published version with my fixes to parser or just clone it from https://github.com/armano2/typescript-eslint-parser till its not ready i did some cleanup in no-unused-vars :) |
c50b78a
to
8b77805
Compare
do you want me to add test scenario for #143? it's not really related to this code but to fix in visitor. i tested it locally with new parser and its working correctly. |
so close...! |
@bradzacher there is new version of |
683a4c2
to
7cf0b22
Compare
awesome! I'll give it one final eyeball now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's actually ridiculous how much the combination of new parser nodes + visitorKeys
+ eslint selectors simplify this entire plugin.
great work all round @armano2.
I owe you a 🍺 for upgrading to selectors and fixing so many parser bugs for us.
To make it work this PR has to be merged due to bug in visitor-tree
Fix: missing visitor-keys eslint/typescript-eslint-parser#554Fix: visitor-keys for TSAbstractClassProperty eslint/typescript-eslint-parser#560Fix: visiting superTypeParameters in classes eslint/typescript-eslint-parser#561Fix: visiting implements in classes eslint/typescript-eslint-parser#562Fix: visiting typeParameters in expressions eslint/typescript-eslint-parser#565Fix: scope for TSImportEqualsDeclaration eslint/typescript-eslint-parser#571New release oftypescript-eslint-parser
unblocks #117, #181 PR
fixes: #152, #155, #126, #164, #166, #171, #193, #189, #143, #33