Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Migrate typescript-eslint-parser to 21.0.2 #174

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

@weirdpattern
Copy link
Collaborator

This looks so much cleaner... thank you @armano2 .
Hoping the new version of the parser gets released soon...

@armano2
Copy link
Contributor Author

armano2 commented Nov 21, 2018

@weirdpattern big part of no-unused-vars its going to be replaced by "ClassImplements Identifier" but only after issues from eslint/typescript-eslint-parser#555 are going to be fixed,

additionally i found some issues in this and old version, any keyword is not always catched, due to visitor and its listed eslint/typescript-eslint-parser#555

class Foo<T extends any = any> extends Foo<any> {}

non of them is going to be reported

@bradzacher
Copy link
Owner

I should go through and read up on the new nodes.
It looks like they've added a lot of really helpful stuff to make dealing with the AST easier!

@armano2
Copy link
Contributor Author

armano2 commented Nov 22, 2018

@bradzacher @weirdpattern for everyone who wants to try new version i suggest to use npm/@armano/typescript-eslint-parser i published version with my fixes to parser or just clone it from https://github.com/armano2/typescript-eslint-parser till its not ready

i did some cleanup in no-unused-vars :)

@armano2 armano2 changed the title Migrate typescript-eslint-parser to 21.0.1 Migrate typescript-eslint-parser to 21.* Nov 24, 2018
@armano2 armano2 mentioned this pull request Nov 24, 2018
@armano2 armano2 force-pushed the typescript-eslint-parser-21 branch 2 times, most recently from c50b78a to 8b77805 Compare November 28, 2018 21:06
@armano2
Copy link
Contributor Author

armano2 commented Nov 28, 2018

do you want me to add test scenario for #143? it's not really related to this code but to fix in visitor.

i tested it locally with new parser and its working correctly.

@bradzacher
Copy link
Owner

so close...!

@armano2
Copy link
Contributor Author

armano2 commented Dec 3, 2018

@bradzacher there is new version of typescript-eslint-parser available.

@armano2 armano2 changed the title Migrate typescript-eslint-parser to 21.* Migrate typescript-eslint-parser to 21.0.2 Dec 4, 2018
@armano2 armano2 force-pushed the typescript-eslint-parser-21 branch from 683a4c2 to 7cf0b22 Compare December 4, 2018 00:43
@bradzacher
Copy link
Owner

awesome! I'll give it one final eyeball now

Copy link
Owner

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's actually ridiculous how much the combination of new parser nodes + visitorKeys + eslint selectors simplify this entire plugin.

great work all round @armano2.
I owe you a 🍺 for upgrading to selectors and fixing so many parser bugs for us.

@bradzacher bradzacher merged commit 4e10d6a into bradzacher:master Dec 4, 2018
@armano2 armano2 deleted the typescript-eslint-parser-21 branch December 4, 2018 03:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[type-annotation-spacing] fails in object types under different conditions
3 participants