-
Notifications
You must be signed in to change notification settings - Fork 63
chore: update package dependencies (fixes #184) #186
chore: update package dependencies (fixes #184) #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually - considering this is for 1.0.0
Could you please make the change described here:
eslint/eslint#11127 (comment)
It'll let us create a direct dependency on the parser, so we only "allow" people to use the tested version of it.
(also update the readme please :)
// eslint-plugin-foo/parser.js
module.exports = require('mylanguage-parser-eslint')
// eslint-plugin-foo
module.exports.rules = rules;
// .eslintrc
{
"parser": "eslint-plugin-foo/parser",
"plugins": [
"foo"
]
}
Adding the 1.0.0 milestone based on this
This looks great, pretty sure is going to help reducing the number of false positives caused by using an unsupported parser. I will take care of this tonight. |
Updates package dependencies and introduces eslint and typescript-eslint-parser as peer dependencies
4d737e1
to
3cc2242
Compare
@bradzacher alright, this should be ready for one last code review and merge... By the way, I'm seeing some odd behaviors after #182 was merged... I think the .vscode/settings.json eslint.validate autofix option is in direct conflict with Good examples of this are:
I should probably create a bug for this... just want you to double check, maybe is something I'm doing wrong? |
hmm. have you got the Prettier extension installed? |
And I just updated the package.json with the lint-staged change that you just merged |
Ah - you have beautify extension. Either way, I've disabled automatic formatting in #192 |
I was pretty sure it was something with my configuration... 😄 |
Updates package dependencies and introduces eslint and typescript-eslint-parser as peer dependencies
Considerations: