-
-
Notifications
You must be signed in to change notification settings - Fork 75
Fix: visiting superTypeParameters in classes #561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@platinumazure should i put each one of missing visitor key in each own PR or should i make one big PR? |
@armano2 Up to you. Please spare a thought for the poor reviewer that has to review a 1000+ line PR 😄 But if it's not that big, you could do one or a few PRs rather than one per node type. |
its more than 1k line with tests xd, i'm asking because some stuff do collide lets say, i made overview in #555 |
@armano2 I would say do what is most convenient for you and worst case, we can ask for changes. I'm not super worried-- I trust you will have good judgment. (If there are areas of code where collisions would happen, let's do those in combined PRs to make things easier.) |
its already supported in visitClass
its using same logic as ClassDeclaration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@armano2 Merged, thanks for contributing! |
This PR is adding
superTypeParameters
to class like typesClassDeclaration
,ClassExpression
,TSAbstractClassDeclaration
and fixes order ofTSAbstractClassDeclaration