Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

Fix: visiting typeParameters in expressions #565

Merged
merged 2 commits into from
Nov 28, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Nov 22, 2018

No description provided.

@armano2 armano2 mentioned this pull request Nov 22, 2018
14 tasks
analyze-scope.js Outdated Show resolved Hide resolved
analyze-scope.js Outdated Show resolved Hide resolved
Copy link
Member

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@armano2
Copy link
Contributor Author

armano2 commented Nov 24, 2018

@kaicataldo can i have some estimate, when those changes can be merged?

@armano2 armano2 changed the title Fix: missing typeParameters in expressions Fix: visiting typeParameters in expressions Nov 24, 2018
@j-f1
Copy link
Contributor

j-f1 commented Nov 25, 2018

@armano2 Last Thursday was Thanksgiving in the US, so it’s possible that some of the maintainers have taken the weekend off and will take another look tomorrow.

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit 83dbabb into eslint:master Nov 28, 2018
@platinumazure
Copy link
Member

@armano2 Merged, thanks for contributing!

@armano2 armano2 deleted the patch-6 branch November 28, 2018 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants