This repository has been archived by the owner on Jan 19, 2019. It is now read-only.
Fix: visitor-keys for TSAbstractClassProperty #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
its already supported in ClassProperty
armano2
changed the title
armano2
changed the title
armano2
changed the title
7 tasks
|
@platinumazure can i have some info when those fixes can be merged? |
|
@armano2 Apologies, I guess we haven't coalesced on if any of the maintainers currently working on this project will act as "lead maintainer" or "PR merger". As you may know, we're still somewhat in transition since the previous lead maintainer left the project. I can merge a few of these since we've had more than just my review (I don't consider myself a TypeScript expert or anywhere near, so I don't want to merge anything on my own). Thanks very much for your patience as I ramp up on this project a little more and as the ESLint team figures out the best way to move forward! |
|
@armano2 I've merged this one, thanks for contributing! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes order of visiting in TSAbstractClassProperty and adds
decoratosdecoratos are already in scope analyze handled by
ClassProperty