Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psammead package bumps #2407

Closed
wants to merge 10 commits into from
Closed

Psammead package bumps #2407

wants to merge 10 commits into from

Conversation

jroebu14
Copy link
Contributor

@jroebu14 jroebu14 commented Jul 10, 2019 •
edited by thekp
Loading

Overall change: #2328
Code changes:

  • update psammead-image-placeholder from 1.0.1 to 1.0.2
    | 1.0.2 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |

  • update psammead-copyright from 1.0.2 to 1.0.3
    | 1.0.3 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |

  • update psammead-media-indicator from 1.0.3 to 1.1.1
    | 1.1.1 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.1.0 | PR#776 Add topStory prop, change padding <400px and bump dependencies |
    | 1.0.5 | PR#788 Use rem for the width and height of the Media SVGs |
    | 1.0.4 | PR#769 Fix stories not appearing in storybook when using install:packages:link |

  • update psammead-story-promo-list from 1.0.2 to 1.0.3
    | 1.0.3 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |

  • update psammead-consent-banner from 1.0.0 to 1.0.2
    | 1.0.2 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.0.1 | PR#713 Update styled-components to 4.3.2 |

  • update psammead-caption from 1.1.7 to 1.1.11
    | 1.1.11 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.1.10 | PR#769 Fix stories not appearing in storybook when using install:packages:link |
    | 1.1.9 | PR#745 Use @bbc/[email protected] and update 'with inline link' story |
    | 1.1.8 | PR#763 Change text colour to C_CLOUD_DARK for C_METAL |

  • update psammead-paragraph from 1.0.5 to 1.0.9
    | 1.0.9 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.0.8 | PR#769 Fix stories not appearing in storybook when using install:packages:link |
    | 1.0.7 | PR#746 Use @bbc/[email protected] and add a 'with inline link' story |
    | 1.0.6 | PR#713 Update styled-components to 4.3.2 |

  • update psammead-storybook-helpers from 3.1.0 to 3.1.1
    | 3.1.1 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |

  • update psammead-brand from 4.1.4 to 4.1.8
    | 4.1.8 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 4.1.7 | PR#787 Fix brand colour in Firefox high contrast mode |
    | 4.1.6 | PR#789 Use rem for the BrandSvg height |
    | 4.1.5 | PR#769 Fix stories not appearing in storybook when using install:packages:link |

  • update psammead-sitewide-links from 1.0.2 to 1.0.4
    | 1.0.4 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.0.3 | PR#769 Fix stories not appearing in storybook when using install:packages:link |

  • update psammead-navigation from 1.0.1 to 1.0.3
    | 1.0.3 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.0.2 | PR#769 Fix stories not appearing in storybook when using install:packages:link |

  • update psammead-assets from 1.0.2 to 1.0.4
    | 1.0.4 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.0.3 | PR#787 Fix brand stories in Firefox high contrast mode |

  • update psammead-figure from 1.0.2 to 1.0.4
    | 1.0.4 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.0.3 | PR#769 Fix stories not appearing in storybook when using install:packages:link |

  • update psammead-section-label from 1.0.2 to 1.0.4
    | 1.0.4 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.0.3 | PR#769 Fix stories not appearing in storybook when using install:packages:link |

  • update psammead-headings from 2.0.2 to 2.0.4
    | 2.0.4 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 2.0.3 | PR#769 Fix stories not appearing in storybook when using install:packages:link |
    | 2.0.2 | PR#713 Update styled-components to 4.3.2 |

  • update psammead-story-promo from 1.0.0-alpha.4 to 1.1.0-alpha.6
    | 1.0.0-alpha.6 | PR#893 Fix knobs for story promo stories |
    | 1.0.0-alpha.5 | PR#769 Fix stories not appearing in storybook when using install:packages:link |

  • update psammead-inline-link from 1.1.0 to 1.1.6
    | 1.1.6 | PR#942 Revert new inline-link styling due to bug |
    | 1.1.5 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.1.4 | PR#769 Fix stories not appearing in storybook when using install:packages:link |
    | 1.1.3 | PR#775 Add section to readme regarding using this component without a wrapper and padding/margin |
    | 1.1.2 | PR#687 Change visited text colour to C_CLOUD_DARK for C_METAL |
    | 1.1.1 | PR#761 Link default color should be Ebon not Postbox |

  • update psammead-styles from 1.0.0 to 1.1.2
    | 1.1.2 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.1.1 | PR#769 Fix stories not appearing in storybook when using install:packages:link |
    | 1.1.0 | PR#764 Add function to get serif bold font |
    | 1.0.1 | PR#677 Use @bbc/[email protected] |

  • update psammead-visually-hidden-text from 1.0.1 to 1.0.3
    | 1.0.3 | PR#783 Update to latest psammead-test-helpers. Update snapshots. |
    | 1.0.2 | PR#769 Fix stories not appearing in storybook when using install:packages:link |

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

Jonathan Roebuck added 2 commits July 10, 2019 08:42
update to latest psammead modules
0431c60 
update psammead-image-placeholder to 1.0.2
update psammead-copyright to 1.0.3
update psammead-media-indicator to 1.1.1
update psammead-story-promo-list to 1.0.3
update psammead-consent-banner to 1.0.2
update psammead-caption to 1.1.11
update psammead-paragraph to 1.0.9
update psammead-storybook-helpers to 3.1.1
update psammead-brand to 4.1.8
update psammead-sitewide-links to 1.0.4
update psammead-navigation to 1.0.2
update psammead-assets to 1.0.3
update psammead-figure to 1.0.3
update psammead-section-label to 1.0.3
update psammead-headings to 2.0.3
update psammead-story-promo to 1.0.0-alpha.5
update psammead-inline-link to 1.1.4
update psammead-styles to 1.1.1
update psammead-visually-hidden-text to 1.0.2
update snapshots
bd39415
@jroebu14 jroebu14 self-assigned this Jul 10, 2019
This was referenced Jul 10, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 10, 2019
Closed
Closed
Closed
dr3
dr3 previously requested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jroebu14 Can you check psammead package changelogs for what changes we expect to propogate please?

Jonathan Roebuck added 2 commits July 10, 2019 09:30
update to latest psammead modules
06ca1a3 
update psammead-assets 1.0.4
update psammead-figure 1.0.4
update psammead-headings 2.0.4
update psammead-inline-link 1.1.6
update psammead-navigation 1.0.3
update psammead-section-label 1.0.4
update psammead-story-promo 0.1.4
update psammead-styles 1.1.2
update psammead-visually-hidden-text 1.0.3
use alpha version of psammead-story-promo
1a87b8a 
psammead-story-promo - 1.0.0-alpha.6
@jroebu14
Copy link
Contributor Author

@dr3 I've included the changelogs in the PR description

chris-hinds
chris-hinds approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@chris-hinds chris-hinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the changelogs.

@dr3 dr3 dismissed their stale review July 10, 2019 09:39

Stale

dr3
dr3 approved these changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@dr3 dr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test WITH CAUTION, checking each of the changes in the PR description

@PriyaKR
Copy link
Contributor

PriyaKR commented Jul 10, 2019

Testing: https://github.com/bbc/psammead/pull/1038 has to be merged before this has been picked up for testing.

@jamesbhobbs
Copy link
Contributor

Closing as we have many deps lower in tree to update.

@jamesbhobbs jamesbhobbs deleted the psammead-package-bumps branch July 14, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-hinds chris-hinds chris-hinds approved these changes

@dr3 dr3 dr3 approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@jamesdonoh jamesdonoh Awaiting requested review from jamesdonoh

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@pjlee11 pjlee11 Awaiting requested review from pjlee11

@sareh sareh Awaiting requested review from sareh

Assignees

@jroebu14 jroebu14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jroebu14 @PriyaKR @jamesbhobbs @dr3 @chris-hinds