You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjlee11
added
blocked
This issue should not be worked on until another internal issue is completed - see desc for details
ws-articles
Tasks for the WS Articles Team
labels
Jul 1, 2019
Discussing this with @jamesbrumpton & @nataliesmart:
When the text for the link is exactly the width of the viewport and you hover/focus, the styling adds padding of 2px on each side and therefore pushes a word down onto the next line. This jump is quite jarring. [1]
However, we discussed how the inline link item is to be used within an article body only - so in a paragraph in the main body copy, or a paragraph within a caption (for an image or video) and in all these scenarios, the components have a minimum of 8px spacing on either side of the text. So this 'jumping' behaviour will not be seen in an Article. [2]
However, we should add a note to the Readme of this component, under usage, to strongly suggest margin or padding on the left and right of 2px or more, whenever using this in production.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #721
Overall change: Adds a story for the Paragraph to contain an Inline Link and pulls in @bbc/[email protected]
Code changes:
@bbc/[email protected]