This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Brand - High contrast colour in Firefox #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12
added
high priority
ws-articles
12
commented
Jul 5, 2019
12
commented
Jul 5, 2019
oluoluoxenfree
approved these changes
Jul 5, 2019
j-pendlebury
approved these changes
Jul 5, 2019
|
LGTM |
|
LGTM |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #736
Overall change: Sets SVG fill to be
currentColorto enable the SVG to be seen in Firefox when the end-user has changed their colour preferences, or enabled high contrast mode.Note: This was already working in IE
Firefox before:
Firefox after:
Code changes:
psammead-brandto pull in latestpsammead-assetspsammead-brandto inherit thecurrentColorto use as the SVGfillpsammead-assetsstories to display the SVG in high contrast mode