Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add method to get serifbold font #764

Merged
merged 7 commits into from
Jul 4, 2019
Merged

Add method to get serifbold font #764

merged 7 commits into from
Jul 4, 2019

Conversation

EinsteinNjoroge
Copy link
Contributor

@EinsteinNjoroge EinsteinNjoroge commented Jul 3, 2019 •
edited
Loading

Resolves #717

Overall change: Add a method to get serifBold font in font styles.

Code changes:

  • Create a getSerifBold method in /font-styles.
  • Adds a serifBold font for news service.
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@EinsteinNjoroge EinsteinNjoroge added blocking ws-home Tasks for the WS Home Team labels Jul 3, 2019
@EinsteinNjoroge EinsteinNjoroge self-assigned this Jul 3, 2019
@EinsteinNjoroge EinsteinNjoroge changed the title Add getserif bold in font styles Add method to get serifbold font Jul 3, 2019
@EinsteinNjoroge EinsteinNjoroge marked this pull request as ready for review July 3, 2019 11:57
DenisHdz
DenisHdz approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ghost
ghost reviewed Jul 3, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very tiny thing.

@david-boydell david-boydell self-assigned this Jul 4, 2019
@david-boydell
Copy link

Looks good, this is ready for merge.

@DenisHdz DenisHdz merged commit 956c5f7 into latest Jul 4, 2019
@DenisHdz DenisHdz deleted the add-getserif-bold-in-font-styles branch July 4, 2019 13:29
@jroebu14 jroebu14 mentioned this pull request Jul 10, 2019
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DenisHdz DenisHdz DenisHdz approved these changes

@dr3 dr3 dr3 approved these changes

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@pjlee11 pjlee11 Awaiting requested review from pjlee11

@sareh sareh Awaiting requested review from sareh

Assignees

@EinsteinNjoroge EinsteinNjoroge

@david-boydell david-boydell

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add getSerifBold in @bbc/psammead-styles/font-styles
4 participants
@EinsteinNjoroge @david-boydell @dr3 @DenisHdz