This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Update psammead snapshots #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroebu14
requested review from
dr3,
j-pendlebury,
pjlee11 and
sareh
as code owners
|
i think for each package you've updated, you will have to update the respective package.json version and update the changelog. so that it can be republished on NPM. |
added 2 commits
July 8, 2019 09:21
Bump package versions for psammead-brand, psammead-caption, psammead-consent-banner, psammead-copyright, psammead-figure, psammead-headings, psammead-image-placeholder, psammead-image, psammead-inline-link, psammead-media-indicator, psammead-navigation, psammead-paragraph, psammead-section-label, psammead-sitewide-links, psammead-story-promo-list, psammead-story-promo, psammead-timestamp, psammead-visually-hidden-text, psammead-timestamp-container, gel-foundations, psammead-assets, psammead-storybook-helpers, psammead-styles
Updates changelogs for psammead-brand, psammead-caption, psammead-consent-banner, psammead-copyright, psammead-figure, psammead-headings, psammead-image-placeholder, psammead-image, psammead-inline-link, psammead-media-indicator, psammead-navigation, psammead-paragraph, psammead-section-label, psammead-sitewide-links, psammead-story-promo-list, psammead-story-promo, psammead-timestamp, psammead-visually-hidden-text, psammead-timestamp-container, gel-foundations, psammead-assets, psammead-storybook-helpers, psammead-styles
jroebu14
force-pushed
the
update-psammead-snapshots
branch
from
c79e25a to
595ca87
Compare
thekp
suggested changes
Jul 8, 2019
|
@thekp whoa good catch! |
jroebu14
force-pushed
the
update-psammead-snapshots
branch
from
f4c82bf to
595ca87
Compare
thekp
approved these changes
Jul 8, 2019
dr3
suggested changes
Jul 8, 2019
added 3 commits
July 9, 2019 08:33
Bump package versions for psammead-brand, psammead-caption, psammead-consent-banner, psammead-copyright, psammead-figure, psammead-headings, psammead-image-placeholder, psammead-image, psammead-inline-link, psammead-media-indicator, psammead-navigation, psammead-paragraph, psammead-section-label, psammead-sitewide-links, psammead-story-promo-list, psammead-story-promo, psammead-timestamp, psammead-visually-hidden-text, psammead-timestamp-container, gel-foundations, psammead-assets, psammead-storybook-helpers, psammead-styles
Updates changelogs for psammead-brand, psammead-caption, psammead-consent-banner, psammead-copyright, psammead-figure, psammead-headings, psammead-image-placeholder, psammead-image, psammead-inline-link, psammead-media-indicator, psammead-navigation, psammead-paragraph, psammead-section-label, psammead-sitewide-links, psammead-story-promo-list, psammead-story-promo, psammead-timestamp, psammead-visually-hidden-text, psammead-timestamp-container, gel-foundations, psammead-assets, psammead-storybook-helpers, psammead-styles
jroebu14
force-pushed
the
update-psammead-snapshots
branch
from
2ec9299 to
c61b3df
Compare
added 10 commits
July 9, 2019 09:29
…nto update-psammead-snapshots
dr3
approved these changes
Jul 9, 2019
ryanmccombe
approved these changes
Jul 9, 2019
|
Doesn't need a testing from a tester. |
3 tasks
3 tasks
This was referenced Jul 12, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #276
Overall change: Updates all Psammead's packages to the latest version of
psammead-test-helpersto make use of new snapshot generator helper that now uses@testing-library/react.Code changes:
package.jsonfiles containingpsammead-test-helpersupgraded to1.0.1package-lock.jsonfiles regeneratedupdateSnapshotsscript to regenerate snapshot filesTesting notes
These changes should only affect our test snapshots and nothing user-facing. The risk of regression is low so probably none to minimal testing required.