Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update Psammead snapshots (react-testing-library) #276

Closed
1 task done
radiocontrolled opened this issue Jan 16, 2019 · 4 comments · Fixed by #783
Closed
1 task done

Update Psammead snapshots (react-testing-library) #276

radiocontrolled opened this issue Jan 16, 2019 · 4 comments · Fixed by #783
Assignees
@jroebu14
Labels
blocked This issue should not be worked on until another internal issue is completed - see desc for details simorgh-core-stream

Comments

@radiocontrolled
Copy link
Contributor

Is your feature request related to a problem? Please describe.
After #273 is complete, the Psammead snapshots should be updated.

The package.json version numbers will have to be updated.
@radiocontrolled radiocontrolled added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jan 16, 2019
@radiocontrolled
Copy link
Contributor Author

Blocked on #273

@PriyaKR PriyaKR added investigation and removed blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Jun 14, 2019
@PriyaKR
Copy link
Contributor

PriyaKR commented Jun 14, 2019 •
edited
Loading

Associated PR Use react-testing-library for Simorgh bbc/simorgh#1182 is now closed and this mainly requires updating the snapshots using react-testing-library.

@jroebu14
Copy link
Contributor

jroebu14 commented Jun 17, 2019 •
edited
Loading

react-testing-library has only been implemented in Simorgh. Before picking up this issue we need to complete #273 to implement react-testing-library* in Psammead.

*react-testing-library is now called @testing-library/react.

@chris-hinds chris-hinds added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Jun 20, 2019
@chris-hinds
Copy link
Contributor

blocked on #273

This was referenced Jun 28, 2019
Closed
Closed
Merged
@jroebu14 jroebu14 self-assigned this Jul 5, 2019
@jroebu14 jroebu14 mentioned this issue Jul 5, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jroebu14 jroebu14

Labels
blocked This issue should not be worked on until another internal issue is completed - see desc for details simorgh-core-stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update psammead snapshots BBC-archive/psammead
6 participants
@radiocontrolled @jroebu14 @ChrisBAshton @PriyaKR @chris-hinds @jamesbhobbs