Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull in @bbc/psammead-brand@latest and update snapshots #2430

Closed
wants to merge 4 commits into from
Closed

Pull in @bbc/psammead-brand@latest and update snapshots #2430

wants to merge 4 commits into from

Conversation

12
Copy link
Contributor

@12 12 commented Jul 11, 2019

Resolves #2314

Overall change:
Pulls in new version of psammead-brand to fix high contrast accessibility issue, also pulls in work from:

Code changes:

  • Update package.json & package_lock.json
  • Updates snapshots to expect changes
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@12 12 added a11y Accessibility-related task ws-articles Tasks for the WS Articles Team articles-av-epic Current focus for the articles features stream labels Jul 11, 2019
@12 12 self-assigned this Jul 11, 2019
@twinlensreflex twinlensreflex mentioned this pull request Jul 11, 2019
Closed
3 tasks
twinlensreflex
twinlensreflex approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@twinlensreflex twinlensreflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@jamesbhobbs jamesbhobbs deleted the update-brand-v branch July 14, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twinlensreflex twinlensreflex twinlensreflex approved these changes

@dr3 dr3 dr3 approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@chris-hinds chris-hinds Awaiting requested review from chris-hinds

@jamesdonoh jamesdonoh Awaiting requested review from jamesdonoh

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@pjlee11 pjlee11 Awaiting requested review from pjlee11

@sareh sareh Awaiting requested review from sareh

Assignees

@12 12

Labels
a11y Accessibility-related task articles-av-epic Current focus for the articles features stream ws-articles Tasks for the WS Articles Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pull in new version of psammead-brand
4 participants
@12 @dr3 @twinlensreflex @jamesbhobbs