Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in @bbc/psammead-brand@latest and update snapshots #2430

Closed
wants to merge 4 commits into from
Closed

Pull in @bbc/psammead-brand@latest and update snapshots #2430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00695b0
Pull in @bbc/psammead-brand@latest and update snapshots
12 Jul 11, 2019
212db08
Merge branch 'latest' into update-brand-v
12 Jul 11, 2019
0de3a8f
Increase bundle expected sizes
12 Jul 11, 2019
29621b7
Merge branch 'update-brand-v' of github.com:bbc/simorgh into update-b…
12 Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
"@babel/runtime": "^7.3.4",
"@bbc/gel-foundations": "3.0.1",
"@bbc/psammead-assets": "^1.0.2",
"@bbc/psammead-brand": "^4.1.2",
"@bbc/psammead-brand": "^4.1.9",
"@bbc/psammead-caption": "^1.1.7",
"@bbc/psammead-consent-banner": "^1.0.0",
"@bbc/psammead-copyright": "^1.0.2",
Expand Down
4 changes: 2 additions & 2 deletions scripts/bundleSize.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

# Size limit for all bundles used by each service (K)
# Keep these +/- 5K and update frequently!
min=604
max=622
min=609
max=629

services=( "news" "persian" "igbo" "yoruba" "pidgin" )
failure=false
Expand Down
5 changes: 4 additions & 1 deletion src/app/containers/Brand/__snapshots__/index.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ exports[`BrandContainer should render correctly 1`] = `
overflow: hidden;
position: absolute;
width: 1px;
margin: 0;
}

.c1 {
Expand All @@ -33,9 +34,11 @@ exports[`BrandContainer should render correctly 1`] = `

.c4 {
box-sizing: content-box;
fill: #FFFFFF;
color: #FFFFFF;
fill: currentColor;
padding-top: 1rem;
padding-bottom: 0.75rem;
height: 1.5rem;
width: 100%;
max-width: 10.496849999999998rem;
min-width: 6.9979rem;
Expand Down
5 changes: 4 additions & 1 deletion src/app/containers/Header/__snapshots__/index.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ exports[`Header should render correctly 1`] = `
overflow: hidden;
position: absolute;
width: 1px;
margin: 0;
}

.c1 {
Expand All @@ -34,9 +35,11 @@ exports[`Header should render correctly 1`] = `

.c4 {
box-sizing: content-box;
fill: #FFFFFF;
color: #FFFFFF;
fill: currentColor;
padding-top: 1rem;
padding-bottom: 0.75rem;
height: 1.5rem;
width: 100%;
max-width: 10.496849999999998rem;
min-width: 6.9979rem;
Expand Down
10 changes: 8 additions & 2 deletions src/app/containers/PageHandlers/__snapshots__/withPageWrapper.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Array [
overflow: hidden;
position: absolute;
width: 1px;
margin: 0;
}

.c1 {
Expand All @@ -35,9 +36,11 @@ Array [

.c4 {
box-sizing: content-box;
fill: #FFFFFF;
color: #FFFFFF;
fill: currentColor;
padding-top: 1rem;
padding-bottom: 0.75rem;
height: 1.5rem;
width: 100%;
max-width: 10.496849999999998rem;
min-width: 6.9979rem;
Expand Down Expand Up @@ -126,6 +129,7 @@ Array [
overflow: hidden;
position: absolute;
width: 1px;
margin: 0;
}

.c2 {
Expand All @@ -150,9 +154,11 @@ Array [

.c5 {
box-sizing: content-box;
fill: #FFFFFF;
color: #FFFFFF;
fill: currentColor;
padding-top: 1rem;
padding-bottom: 0.75rem;
height: 1.5rem;
width: 100%;
max-width: 10.496849999999998rem;
min-width: 6.9979rem;
Expand Down