Updates psammead-brand to fix high-contrast accessibility issue #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twinlensreflex
added
a11y
twinlensreflex
requested review from
jamesbhobbs,
dr3,
chris-hinds,
jamesdonoh,
j-pendlebury,
pjlee11 and
sareh
as code owners
dr3
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
LGTM, this also pulls in BBC-archive/psammead#789, fixing the small brand when you increase fontsize, could you pop this in the PR description please to ensure its checked by testers :)
oluoluoxenfree
approved these changes
Jul 9, 2019
|
closed on #2430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2314
Overall change:
Pulls in new version of
psammead-brandto fix high contrast accessibility issue, also pulls in work from BBC-archive/psammead#7894.1.6which adds height to make the Brand SVG scale as the text is resized.Code changes:
package.json&package_lock.json