Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logger_level_reconfigure_plugin): use node interface and some cosmetic updates #5204

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Oct 2, 2023

Description

Update logger level reconfigure plugin.

Special thanks to Chat-GPT. This revision is mostly done by his implementation.

logger_level-2023-10-02_20.06.07.mp4

Related links

None

Tests performed

run psim

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Oct 2, 2023
@TakaHoribe TakaHoribe changed the title Logger level reconfigure update feat(logger_level_reconfigure_plugin): use node interface and some cosmetic updates Oct 2, 2023
@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 2, 2023
Signed-off-by: Takamasa Horibe <[email protected]>
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (c99c6b2) 14.76% compared to head (a99c85a) 14.76%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5204   +/-   ##
=======================================
  Coverage   14.76%   14.76%           
=======================================
  Files        1636     1636           
  Lines      113582   113576    -6     
  Branches    34903    34903           
=======================================
  Hits        16769    16769           
+ Misses      77985    77979    -6     
  Partials    18828    18828           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.77% <0.00%> (+<0.01%) ⬆️ Carriedforward from 3e13745

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...figure_rviz_plugin/src/logging_level_configure.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TakaHoribe TakaHoribe enabled auto-merge (squash) October 2, 2023 11:59
@TakaHoribe TakaHoribe merged commit bab1453 into autowarefoundation:main Oct 2, 2023
@TakaHoribe TakaHoribe deleted the logger-level-reconfigure-update branch October 2, 2023 12:01
TakaHoribe added a commit to tier4/autoware.universe that referenced this pull request Oct 15, 2023
…smetic updates (autowarefoundation#5204)

* use node service

Signed-off-by: Takamasa Horibe <[email protected]>

* enable yaml configuration

Signed-off-by: Takamasa Horibe <[email protected]>

* update yaml loading

Signed-off-by: Takamasa Horibe <[email protected]>

* make it scrollable

Signed-off-by: Takamasa Horibe <[email protected]>

* change function order

Signed-off-by: Takamasa Horibe <[email protected]>

* change color for level

Signed-off-by: Takamasa Horibe <[email protected]>

* fix depend

Signed-off-by: Takamasa Horibe <[email protected]>

* Update common/tier4_logging_level_configure_rviz_plugin/src/logging_level_configure.cpp

Co-authored-by: Kosuke Takeuchi <[email protected]>

* Update common/tier4_logging_level_configure_rviz_plugin/src/logging_level_configure.cpp

---------

Signed-off-by: Takamasa Horibe <[email protected]>
Co-authored-by: Kosuke Takeuchi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants