-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logger_level_reconfigure_plugin): use node interface and some cosmetic updates #5204
Merged
TakaHoribe
merged 9 commits into
autowarefoundation:main
from
tier4:logger-level-reconfigure-update
Oct 2, 2023
Merged
feat(logger_level_reconfigure_plugin): use node interface and some cosmetic updates #5204
TakaHoribe
merged 9 commits into
autowarefoundation:main
from
tier4:logger-level-reconfigure-update
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: Takamasa Horibe <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5204 +/- ##
=======================================
Coverage 14.76% 14.76%
=======================================
Files 1636 1636
Lines 113582 113576 -6
Branches 34903 34903
=======================================
Hits 16769 16769
+ Misses 77985 77979 -6
Partials 18828 18828
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kosuke55
reviewed
Oct 2, 2023
common/tier4_logging_level_configure_rviz_plugin/src/logging_level_configure.cpp
Outdated
Show resolved
Hide resolved
kosuke55
approved these changes
Oct 2, 2023
kosuke55
reviewed
Oct 2, 2023
common/tier4_logging_level_configure_rviz_plugin/src/logging_level_configure.cpp
Outdated
Show resolved
Hide resolved
…evel_configure.cpp Co-authored-by: Kosuke Takeuchi <[email protected]>
TakaHoribe
commented
Oct 2, 2023
common/tier4_logging_level_configure_rviz_plugin/src/logging_level_configure.cpp
Outdated
Show resolved
Hide resolved
…evel_configure.cpp
This was referenced Oct 11, 2023
TakaHoribe
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 15, 2023
…smetic updates (autowarefoundation#5204) * use node service Signed-off-by: Takamasa Horibe <[email protected]> * enable yaml configuration Signed-off-by: Takamasa Horibe <[email protected]> * update yaml loading Signed-off-by: Takamasa Horibe <[email protected]> * make it scrollable Signed-off-by: Takamasa Horibe <[email protected]> * change function order Signed-off-by: Takamasa Horibe <[email protected]> * change color for level Signed-off-by: Takamasa Horibe <[email protected]> * fix depend Signed-off-by: Takamasa Horibe <[email protected]> * Update common/tier4_logging_level_configure_rviz_plugin/src/logging_level_configure.cpp Co-authored-by: Kosuke Takeuchi <[email protected]> * Update common/tier4_logging_level_configure_rviz_plugin/src/logging_level_configure.cpp --------- Signed-off-by: Takamasa Horibe <[email protected]> Co-authored-by: Kosuke Takeuchi <[email protected]>
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update logger level reconfigure plugin.
Special thanks to Chat-GPT. This revision is mostly done by his implementation.
logger_level-2023-10-02_20.06.07.mp4
Related links
None
Tests performed
run psim
Notes for reviewers
None
Interface changes
None
Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.