feat(logger_level_configure): make it possible to change level of container logger #6823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
TomohitoAndo,
tkimura4 and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
component:launch
satoshi-ota
changed the title
logging_demo::LoggerConfig into container
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
fix/logger-config
branch
from
08ece4c to
c052f76
Compare
github-actions
bot
added
the
component:planning
satoshi-ota
changed the title
logging_demo::LoggerConfig into container
satoshi-ota
changed the title
satoshi-ota
added
the
run:build-and-test-differential
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 18, 2024
…el of container logger (autowarefoundation#6823)" This reverts commit 51b5f83.
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…tainer logger (autowarefoundation#6823) * feat(launch): add logging_demo::LoggerConfig into container Signed-off-by: satoshi-ota <[email protected]> * fix(logger_level_reconfigure_plugin): fix yaml Signed-off-by: satoshi-ota <[email protected]> * feat(logging_level_configure): add composable node Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…el of container logger (autowarefoundation#6823)" (autowarefoundation#6842) This reverts commit 51b5f83.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have to send service with container name when we change output level of stand alone logger
rclcpp::get_logger. (08ece4c) Additionally, we need to loadlogging_demo::LoggerConfignode to the target container. (3089230)Tests performed
Psim
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.