Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inspect and repair geometry #1697

Closed
wants to merge 38 commits into from
Closed

feat: inspect and repair geometry #1697

wants to merge 38 commits into from

Conversation

smereu
Copy link
Contributor

@smereu smereu commented Jan 28, 2025

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

RobPasMue and others added 30 commits January 10, 2025 11:37
@RobPasMue
ci: simplify ci for blitz
ed028b0
@RobPasMue
ci: simplify ci for blitz
54f3b60
@RobPasMue
Merge branch 'blitz' of https://github.com/ansys/pyansys-geometry int…
4f74754 
…o blitz
@jonahrb @pyansys-ci-bot @RobPasMue
feat: create a fillet on an edge/face (#1621)
e4955c0 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
@jonahrb @pyansys-ci-bot
feat: create a full fillet between multiple faces (#1623)
e79ef3b 
Co-authored-by: pyansys-ci-bot <[email protected]>
@jonahrb @pyansys-ci-bot
feat: extrude existing faces, setup face offset relationships (#1628)
5201f65 
Co-authored-by: pyansys-ci-bot <[email protected]>
@jonahrb @pyansys-ci-bot
feat: extrude existing edges to create surface bodies (#1638)
6b57225 
Co-authored-by: pyansys-ci-bot <[email protected]>
@RobPasMue
build: bump ansys-api-geometry in blitz branch
0b26b26
@RobPasMue
build: using ansys-api-geometry 0.4.29
72049ba
@RobPasMue
build: bump ansys-api-geometry in blitz branch
7c25285
@jonahrb @pyansys-ci-bot
feat: create and modify linear patterns (#1641)
6315fa1 
Co-authored-by: pyansys-ci-bot <[email protected]>
@umutsoysalansys @pyansys-ci-bot @RobPasMue
feat: body suppression state (#1643)
51b8797 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
@jonahrb @pyansys-ci-bot
feat: surface body from trimmed curves (#1650)
b20f1c7 
Co-authored-by: pyansys-ci-bot <[email protected]>
@RyanJWard @pre-commit-ci
@pyansys-ci-bot @jonahrb
test: add more find and fix tests for repair tools (#1645)
4993883 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: jonahrb <[email protected]>
Co-authored-by: Jonah Boling <[email protected]>
@RobPasMue
ci: simplify ci for blitz
c917586
@jonahrb @pyansys-ci-bot @RobPasMue
feat: create a fillet on an edge/face (#1621)
4b71674 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
@jonahrb @pyansys-ci-bot @RobPasMue
feat: create a full fillet between multiple faces (#1623)
4add452 
Co-authored-by: pyansys-ci-bot <[email protected]>
@jonahrb @pyansys-ci-bot @RobPasMue
feat: extrude existing faces, setup face offset relationships (#1628)
17454c9 
Co-authored-by: pyansys-ci-bot <[email protected]>
@jonahrb @pyansys-ci-bot @RobPasMue
feat: extrude existing edges to create surface bodies (#1638)
e89d79d 
Co-authored-by: pyansys-ci-bot <[email protected]>
@jonahrb @pyansys-ci-bot @RobPasMue
feat: create and modify linear patterns (#1641)
b700d7f 
Co-authored-by: pyansys-ci-bot <[email protected]>
@umutsoysalansys @pyansys-ci-bot @RobPasMue
feat: body suppression state (#1643)
6f84751 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
@jonahrb @pyansys-ci-bot @RobPasMue
feat: surface body from trimmed curves (#1650)
e429375 
Co-authored-by: pyansys-ci-bot <[email protected]>
@RyanJWard @pre-commit-ci
@pyansys-ci-bot @jonahrb @RobPasMue
test: add more find and fix tests for repair tools (#1645)
ec8d992 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: jonahrb <[email protected]>
Co-authored-by: Jonah Boling <[email protected]>
@RobPasMue
Merge branch 'blitz' of https://github.com/ansys/pyansys-geometry int…
b55f379 
…o blitz
@jonahrb @pyansys-ci-bot
feat: create circular and fill patterns (#1653)
0ebf4b2 
Co-authored-by: pyansys-ci-bot <[email protected]>
@jacobrkerstetter @pre-commit-ci
@pyansys-ci-bot @RobPasMue
feat: rename object (#1648)
85dcb8b 
Co-authored-by: jkerstet <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
@umutsoysalansys @pyansys-ci-bot
@RobPasMue @PipKat @pre-commit-ci
feat: parameters refurbished (#1647)
034e060 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
Co-authored-by: Kathy Pippert <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@jacobrkerstetter @pyansys-ci-bot
@pre-commit-ci @RobPasMue
feat: replace face (#1664)
65f43c4 
Co-authored-by: jkerstet <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <[email protected]>
@MikeJanes @mdjanes
@pre-commit-ci @pyansys-ci-bot
feat: enable get/set persistent ids for stride import/export (#1671)
0e37d41 
Co-authored-by: Michael Janes <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
@jonahrb @pyansys-ci-bot @RobPasMue
feat: revolve faces a set distance, up to another object, or by a hel…
89382c9 
…ix (#1666)

Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
jacobrkerstetter and others added 8 commits January 21, 2025 21:45
@jacobrkerstetter @pyansys-ci-bot
@pre-commit-ci @jonahrb
feat: find fix simplify (#1661)
212132a 
Co-authored-by: jkerstet <[email protected]>
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jonah Boling <[email protected]>
@RyanJWard @pyansys-ci-bot
@jonahrb @pre-commit-ci
test: Add some new tests (#1670)
0beb35d 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Jonah Boling <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@david-gorman @pyansys-ci-bot @pre-commit-ci
feat: add split body and tests (#1669)
8397962 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@RobPasMue @pyansys-ci-bot
ci: ensure design is closed on test exit (#1680)
546c73b 
Co-authored-by: pyansys-ci-bot <[email protected]>
@b-matteo @pyansys-ci-bot @RobPasMue
build: bump ansys api geometry from 0.4.30 to 0.4.32 (#1677)
0b08f8c 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
@mlkaplan36 @pre-commit-ci @pyansys-ci-bot
feat: find and fix edge methods (#1672)
693590c 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pyansys-ci-bot <[email protected]>
@smereu
Geometry inspectdrepfffair
b1f319e 
first implementation of geometry inspect  and repair
@smereu
clean-up and decorators
6d853bd 
minor clean-up and add-decorators
@smereu smereu self-assigned this Jan 28, 2025
@smereu
Copy link
Contributor Author

smereu commented Jan 28, 2025

@RobPasMue. This PR is not ready for merge but I am creating a draft pull request because I have some questions that I would like to discuss. @PipKat Feel free to review the doc side if you want. It is not likely to change much once the code is complete

@jonahrb jonahrb changed the title Feat: Inspect and repair geometry feat: inspect and repair geometry Jan 28, 2025
@smereu
Copy link
Contributor Author

smereu commented Feb 4, 2025

Abandoning this pull request. Another one has been create for this enhancement

@smereu smereu closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat Awaiting requested review from PipKat PipKat will be requested when the pull request is marked ready for review PipKat is a code owner

Assignees

@smereu smereu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@smereu @RobPasMue @jonahrb @umutsoysalansys @RyanJWard @jacobrkerstetter @MikeJanes @david-gorman @b-matteo @mlkaplan36