Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: body suppression state #1643

Merged
merged 7 commits into from
Jan 17, 2025
Merged

feat: body suppression state #1643

merged 7 commits into from
Jan 17, 2025

Conversation

umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Jan 16, 2025 •
edited
Loading

Description

** Getter setter for body suppression. Didn't put a client side getter to make sure it is always sync with backend. We can add one if it is needed.**

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the enhancement New features or code improvements label Jan 16, 2025
@umutsoysalansys umutsoysalansys changed the title body suppressing feat: body suppressing Jan 16, 2025
@umutsoysalansys umutsoysalansys marked this pull request as ready for review January 16, 2025 15:03
@umutsoysalansys umutsoysalansys requested a review from a team as a code owner January 16, 2025 15:03
@umutsoysalansys umutsoysalansys self-assigned this Jan 16, 2025
@umutsoysalansys umutsoysalansys changed the title feat: body suppressing feat: body suppression state Jan 16, 2025
RobPasMue
RobPasMue approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my small suggestion, LGTM!

tests/integration/test_design.py Outdated Show resolved Hide resolved
@umutsoysalansys umutsoysalansys enabled auto-merge (squash) January 17, 2025 14:16
@umutsoysalansys umutsoysalansys enabled auto-merge (squash) January 17, 2025 18:17
@umutsoysalansys umutsoysalansys merged commit 51b8797 into blitz Jan 17, 2025
24 of 27 checks passed
@umutsoysalansys umutsoysalansys deleted the feat/bodysuppression branch January 17, 2025 18:49
RobPasMue added a commit that referenced this pull request Jan 20, 2025
@umutsoysalansys @pyansys-ci-bot @RobPasMue
feat: body suppression state (#1643)
6f84751 
Co-authored-by: pyansys-ci-bot <[email protected]>
Co-authored-by: Roberto Pastor Muela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@jonahrb jonahrb Awaiting requested review from jonahrb

@smereu smereu Awaiting requested review from smereu

@b-matteo b-matteo Awaiting requested review from b-matteo

Assignees

@umutsoysalansys umutsoysalansys

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umutsoysalansys @RobPasMue @pyansys-ci-bot