Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a full fillet between multiple faces #1623

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Jan 13, 2025

Description

Create a full fillet (round) between a collection of faces.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb requested a review from a team as a code owner January 13, 2025 14:55
@jonahrb jonahrb self-assigned this Jan 13, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Jan 13, 2025
@jonahrb jonahrb requested review from jacobrkerstetter, b-matteo and mlkaplan36 and removed request for b-matteo January 13, 2025 14:57
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (e4955c0) to head (39d3b5f).
Report is 1 commits behind head on blitz.

Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1623      +/-   ##
==========================================
+ Coverage   91.36%   91.37%   +0.01%     
==========================================
  Files          87       87              
  Lines        7147     7156       +9     
==========================================
+ Hits         6530     6539       +9     
  Misses        617      617              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonahrb jonahrb merged commit e79ef3b into blitz Jan 13, 2025
27 checks passed
@jonahrb jonahrb deleted the feat/full-fillet branch January 13, 2025 15:12
RobPasMue pushed a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants