Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: revolve faces a set distance, up to another object, or by a helix #1666

Merged
merged 6 commits into from
Jan 21, 2025
Merged

feat: revolve faces a set distance, up to another object, or by a helix #1666

merged 6 commits into from
Jan 21, 2025

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Jan 20, 2025 •
edited
Loading

Description

Revolve faces around an axis.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Jan 20, 2025
@jonahrb jonahrb requested a review from a team as a code owner January 20, 2025 19:38
@github-actions github-actions bot added the enhancement New features or code improvements label Jan 20, 2025
RobPasMue
RobPasMue approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM - just a small comment

src/ansys/geometry/core/connection/conversions.py Show resolved Hide resolved
@RobPasMue
Copy link
Member

Looks like there are some issues with the helix test ref values. Have a look at them whenever you get the chance @jonahrb

@jonahrb jonahrb enabled auto-merge (squash) January 21, 2025 20:39
@jonahrb jonahrb merged commit 89382c9 into blitz Jan 21, 2025
24 of 26 checks passed
@jonahrb jonahrb deleted the feat/revolve-faces branch January 21, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@jacobrkerstetter jacobrkerstetter Awaiting requested review from jacobrkerstetter

Assignees

@jonahrb jonahrb

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonahrb @RobPasMue @pyansys-ci-bot