Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extrude existing edges to create surface bodies #1638

Merged
merged 6 commits into from
Jan 15, 2025

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Jan 15, 2025

Description

Extrude existing edges a certain distance or up to another object.

Also fixed a bug with design cached bodies not clearing.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Jan 15, 2025
@jonahrb jonahrb requested a review from a team as a code owner January 15, 2025 14:28
@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Jan 15, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonahrb jonahrb merged commit 6b57225 into blitz Jan 15, 2025
25 of 27 checks passed
@jonahrb jonahrb deleted the feat/extrude-edges branch January 15, 2025 15:25
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.35%. Comparing base (5201f65) to head (75e14b3).
Report is 1 commits behind head on blitz.

Files with missing lines Patch % Lines
.../ansys/geometry/core/designer/geometry_commands.py 86.11% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1638      +/-   ##
==========================================
- Coverage   91.38%   91.35%   -0.03%     
==========================================
  Files          87       87              
  Lines        7219     7254      +35     
==========================================
+ Hits         6597     6627      +30     
- Misses        622      627       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

RobPasMue pushed a commit that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants